* [Intel-wired-lan] fm10k: use ethtool_rxfh_indir_default for default redirection table
@ 2016-04-06 18:37 Dan Carpenter
2016-04-06 21:57 ` Keller, Jacob E
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2016-04-06 18:37 UTC (permalink / raw)
To: intel-wired-lan
Hello Jacob Keller,
The patch 0ea7fae44094: "fm10k: use ethtool_rxfh_indir_default for
default redirection table" from Feb 16, 2016, leads to the following
static checker warning:
drivers/net/ethernet/intel/fm10k/fm10k_main.c:1977 fm10k_init_reta()
error: potential null dereference 'indir'. (kcalloc returns null)
drivers/net/ethernet/intel/fm10k/fm10k_main.c
1970
1971 repopulate_reta:
1972 indir = kcalloc(fm10k_get_reta_size(netdev),
1973 sizeof(indir[0]), GFP_KERNEL);
1974
1975 /* generate redirection table using the default kernel policy */
1976 for (i = 0; i < fm10k_get_reta_size(netdev); i++)
1977 indir[i] = ethtool_rxfh_indir_default(i, rss_i);
1978
1979 fm10k_write_reta(interface, indir);
1980
1981 kfree(indir);
1982 }
regards,
dan carpenter
^ permalink raw reply [flat|nested] 2+ messages in thread
* [Intel-wired-lan] fm10k: use ethtool_rxfh_indir_default for default redirection table
2016-04-06 18:37 [Intel-wired-lan] fm10k: use ethtool_rxfh_indir_default for default redirection table Dan Carpenter
@ 2016-04-06 21:57 ` Keller, Jacob E
0 siblings, 0 replies; 2+ messages in thread
From: Keller, Jacob E @ 2016-04-06 21:57 UTC (permalink / raw)
To: intel-wired-lan
On Wed, 2016-04-06 at 21:37 +0300, Dan Carpenter wrote:
> Hello Jacob Keller,
>
> The patch 0ea7fae44094: "fm10k: use ethtool_rxfh_indir_default for
> default redirection table" from Feb 16, 2016, leads to the following
> static checker warning:
>
> drivers/net/ethernet/intel/fm10k/fm10k_main.c:1977
> fm10k_init_reta()
> error: potential null dereference 'indir'.??(kcalloc returns
> null)
>
> drivers/net/ethernet/intel/fm10k/fm10k_main.c
> ? 1970??
> ? 1971??repopulate_reta:
> ? 1972??????????indir = kcalloc(fm10k_get_reta_size(netdev),
> ? 1973??????????????????????????sizeof(indir[0]), GFP_KERNEL);
> ? 1974??
> ? 1975??????????/* generate redirection table using the default
> kernel policy */
> ? 1976??????????for (i = 0; i < fm10k_get_reta_size(netdev); i++)
> ? 1977??????????????????indir[i] = ethtool_rxfh_indir_default(i,
> rss_i);
> ? 1978??
> ? 1979??????????fm10k_write_reta(interface, indir);
> ? 1980??
> ? 1981??????????kfree(indir);
> ? 1982??}
>
>
Oops! Will fix in a v2. Which tool is this caused by?
Thanks,
Jake
> regards,
> dan carpenter
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-04-06 21:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-04-06 18:37 [Intel-wired-lan] fm10k: use ethtool_rxfh_indir_default for default redirection table Dan Carpenter
2016-04-06 21:57 ` Keller, Jacob E
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox