From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [next-queue PATCH v3] i40e/i40evf: Update driver to support napi_complete_done changes
Date: Thu, 05 Jan 2017 14:26:19 -0800 [thread overview]
Message-ID: <1483655179.25700.42.camel@intel.com> (raw)
In-Reply-To: <CAKgT0UeScCSh0uJBNRzQ9V-yrdqQFq1mU1PdE4xwFpYwWxSWNA@mail.gmail.com>
On Thu, 2017-01-05 at 14:05 -0800, Alexander Duyck wrote:
> On Wed, Dec 7, 2016 at 4:14 PM, Alexander Duyck
> <alexander.duyck@gmail.com> wrote:
> > From: Alexander Duyck <alexander.h.duyck@intel.com>
> >
> > Recently napi_complete_done was updated so that it will return zero if
> > we
> > are using the queue vector for busy polling.? When this is the case we
> > don't need to re-enable interrupts as the busy polling will reschedule
> > the
> > NAPI instance when it is finally done polling.
> >
> > Signed-off-by: Alexander Duyck <alexander.h.duyck@intel.com>
> > ---
> >
> > v2: Updated code to place the IRQ enabling inside the if statment
> > ???? This made it so that we are consistent with the recent return
> > value changes
> >
> > v3: Added i40evf changes as well
> >
> > ? drivers/net/ethernet/intel/i40e/i40e_txrx.c?? |?? 32 +++++++++++++---
> > ---------
> > ? drivers/net/ethernet/intel/i40evf/i40e_txrx.c |?? 28 ++++++++++++--
> > --------
> > ? 2 files changed, 32 insertions(+), 28 deletions(-)
> >
>
> Jeff,
>
> This patch causes a performance regression due to the way it interacts
> with the i40e WB on ITR behavior.? Can you please drop it from the
> dev-queue.
I have dropped the patch from my queue/tree.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part
URL: <http://lists.osuosl.org/pipermail/intel-wired-lan/attachments/20170105/d9e4cb64/attachment.asc>
prev parent reply other threads:[~2017-01-05 22:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-08 0:14 [Intel-wired-lan] [next-queue PATCH v3] i40e/i40evf: Update driver to support napi_complete_done changes Alexander Duyck
2016-12-09 23:22 ` Samudrala, Sridhar
2017-01-05 22:05 ` Alexander Duyck
2017-01-05 22:05 ` Alexander Duyck
2017-01-05 22:26 ` Jeff Kirsher [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1483655179.25700.42.camel@intel.com \
--to=jeffrey.t.kirsher@intel.com \
--cc=intel-wired-lan@osuosl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox