* [Intel-wired-lan] [PATCH linux-next] e1000e: Remove redundant statement @ 2021-10-18 8:51 luo penghao 2021-10-18 16:27 ` Jesse Brandeburg 2021-10-19 11:50 ` patchwork-bot+netdevbpf 0 siblings, 2 replies; 3+ messages in thread From: luo penghao @ 2021-10-18 8:51 UTC (permalink / raw) To: intel-wired-lan This assignment statement is meaningless, because the statement will execute to the tag "set_itr_now". The clang_analyzer complains as follows: drivers/net/ethernet/intel/e1000e/netdev.c:2552:3 warning: Value stored to 'current_itr' is never read. Reported-by: Zeal Robot <zealci@zte.com.cn> Signed-off-by: luo penghao <luo.penghao@zte.com.cn> --- drivers/net/ethernet/intel/e1000e/netdev.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/ethernet/intel/e1000e/netdev.c b/drivers/net/ethernet/intel/e1000e/netdev.c index ff8672a..21ec716 100644 --- a/drivers/net/ethernet/intel/e1000e/netdev.c +++ b/drivers/net/ethernet/intel/e1000e/netdev.c @@ -2549,7 +2549,6 @@ static void e1000_set_itr(struct e1000_adapter *adapter) /* for non-gigabit speeds, just fix the interrupt rate at 4000 */ if (adapter->link_speed != SPEED_1000) { - current_itr = 0; new_itr = 4000; goto set_itr_now; } -- 2.15.2 ^ permalink raw reply related [flat|nested] 3+ messages in thread
* [Intel-wired-lan] [PATCH linux-next] e1000e: Remove redundant statement 2021-10-18 8:51 [Intel-wired-lan] [PATCH linux-next] e1000e: Remove redundant statement luo penghao @ 2021-10-18 16:27 ` Jesse Brandeburg 2021-10-19 11:50 ` patchwork-bot+netdevbpf 1 sibling, 0 replies; 3+ messages in thread From: Jesse Brandeburg @ 2021-10-18 16:27 UTC (permalink / raw) To: intel-wired-lan On 10/18/2021 1:51 AM, luo penghao wrote: > This assignment statement is meaningless, because the statement > will execute to the tag "set_itr_now". > > The clang_analyzer complains as follows: > > drivers/net/ethernet/intel/e1000e/netdev.c:2552:3 warning: > > Value stored to 'current_itr' is never read. > > Reported-by: Zeal Robot <zealci@zte.com.cn> > Signed-off-by: luo penghao <luo.penghao@zte.com.cn> Reviewed-by: Jesse Brandeburg <jesse.brandeburg@intel.com> ^ permalink raw reply [flat|nested] 3+ messages in thread
* [Intel-wired-lan] [PATCH linux-next] e1000e: Remove redundant statement 2021-10-18 8:51 [Intel-wired-lan] [PATCH linux-next] e1000e: Remove redundant statement luo penghao 2021-10-18 16:27 ` Jesse Brandeburg @ 2021-10-19 11:50 ` patchwork-bot+netdevbpf 1 sibling, 0 replies; 3+ messages in thread From: patchwork-bot+netdevbpf @ 2021-10-19 11:50 UTC (permalink / raw) To: intel-wired-lan Hello: This patch was applied to netdev/net-next.git (master) by David S. Miller <davem@davemloft.net>: On Mon, 18 Oct 2021 08:51:54 +0000 you wrote: > This assignment statement is meaningless, because the statement > will execute to the tag "set_itr_now". > > The clang_analyzer complains as follows: > > drivers/net/ethernet/intel/e1000e/netdev.c:2552:3 warning: > > [...] Here is the summary with links: - [linux-next] e1000e: Remove redundant statement https://git.kernel.org/netdev/net-next/c/1bd297988b75 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-10-19 11:50 UTC | newest] Thread overview: 3+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2021-10-18 8:51 [Intel-wired-lan] [PATCH linux-next] e1000e: Remove redundant statement luo penghao 2021-10-18 16:27 ` Jesse Brandeburg 2021-10-19 11:50 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox