* [Intel-wired-lan] [PATCH net] igc: Unlock on error in igc_io_resume()
@ 2024-08-29 19:22 Dan Carpenter
2024-08-29 19:26 ` Gerhard Engleder
2024-09-02 12:50 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Dan Carpenter @ 2024-08-29 19:22 UTC (permalink / raw)
To: Sasha Neftin
Cc: Przemek Kitszel, kernel-janitors, linux-kernel, Eric Dumazet,
netdev, Tony Nguyen, intel-wired-lan, Jakub Kicinski, Paolo Abeni,
David S. Miller
Call rtnl_unlock() on this error path, before returning.
Fixes: bc23aa949aeb ("igc: Add pcie error handler support")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
---
drivers/net/ethernet/intel/igc/igc_main.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/intel/igc/igc_main.c b/drivers/net/ethernet/intel/igc/igc_main.c
index dfd6c00b4205..0a095cdea4fb 100644
--- a/drivers/net/ethernet/intel/igc/igc_main.c
+++ b/drivers/net/ethernet/intel/igc/igc_main.c
@@ -7413,6 +7413,7 @@ static void igc_io_resume(struct pci_dev *pdev)
rtnl_lock();
if (netif_running(netdev)) {
if (igc_open(netdev)) {
+ rtnl_unlock();
netdev_err(netdev, "igc_open failed after reset\n");
return;
}
--
2.45.2
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [Intel-wired-lan] [PATCH net] igc: Unlock on error in igc_io_resume()
2024-08-29 19:22 [Intel-wired-lan] [PATCH net] igc: Unlock on error in igc_io_resume() Dan Carpenter
@ 2024-08-29 19:26 ` Gerhard Engleder
2024-09-02 12:50 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Gerhard Engleder @ 2024-08-29 19:26 UTC (permalink / raw)
To: Dan Carpenter, Sasha Neftin
Cc: Przemek Kitszel, kernel-janitors, linux-kernel, Eric Dumazet,
netdev, Tony Nguyen, intel-wired-lan, Jakub Kicinski, Paolo Abeni,
David S. Miller
On 29.08.24 21:22, Dan Carpenter wrote:
> Call rtnl_unlock() on this error path, before returning.
>
> Fixes: bc23aa949aeb ("igc: Add pcie error handler support")
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
> ---
> drivers/net/ethernet/intel/igc/igc_main.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/ethernet/intel/igc/igc_main.c b/drivers/net/ethernet/intel/igc/igc_main.c
> index dfd6c00b4205..0a095cdea4fb 100644
> --- a/drivers/net/ethernet/intel/igc/igc_main.c
> +++ b/drivers/net/ethernet/intel/igc/igc_main.c
> @@ -7413,6 +7413,7 @@ static void igc_io_resume(struct pci_dev *pdev)
> rtnl_lock();
> if (netif_running(netdev)) {
> if (igc_open(netdev)) {
> + rtnl_unlock();
> netdev_err(netdev, "igc_open failed after reset\n");
> return;
> }
Reviewed-by: Gerhard Engleder <gerhard@engleder-embedded.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [Intel-wired-lan] [PATCH net] igc: Unlock on error in igc_io_resume()
2024-08-29 19:22 [Intel-wired-lan] [PATCH net] igc: Unlock on error in igc_io_resume() Dan Carpenter
2024-08-29 19:26 ` Gerhard Engleder
@ 2024-09-02 12:50 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2024-09-02 12:50 UTC (permalink / raw)
To: Dan Carpenter
Cc: sasha.neftin, przemyslaw.kitszel, kernel-janitors, linux-kernel,
edumazet, netdev, anthony.l.nguyen, intel-wired-lan, kuba, pabeni,
davem
Hello:
This patch was applied to netdev/net.git (main)
by David S. Miller <davem@davemloft.net>:
On Thu, 29 Aug 2024 22:22:45 +0300 you wrote:
> Call rtnl_unlock() on this error path, before returning.
>
> Fixes: bc23aa949aeb ("igc: Add pcie error handler support")
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
> ---
> drivers/net/ethernet/intel/igc/igc_main.c | 1 +
> 1 file changed, 1 insertion(+)
Here is the summary with links:
- [net] igc: Unlock on error in igc_io_resume()
https://git.kernel.org/netdev/net/c/ef4a99a0164e
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-09-02 12:50 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-08-29 19:22 [Intel-wired-lan] [PATCH net] igc: Unlock on error in igc_io_resume() Dan Carpenter
2024-08-29 19:26 ` Gerhard Engleder
2024-09-02 12:50 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox