From: Richard Cochran <richardcochran@gmail.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [PATCH 03/12] net: igb: avoid using timespec
Date: Thu, 1 Oct 2015 21:17:45 +0200 [thread overview]
Message-ID: <20151001191745.GC1872@localhost.localdomain> (raw)
In-Reply-To: <1443612402-3000775-4-git-send-email-arnd@arndb.de>
Arnd
As author of these snippets, I went ahead and reviewed. I have one
comment, below.
Reviewed-by: Richard Cochran <richardcochran@gmail.com>
On Wed, Sep 30, 2015 at 01:26:33PM +0200, Arnd Bergmann wrote:
> diff --git a/drivers/net/ethernet/intel/igb/igb_ptp.c b/drivers/net/ethernet/intel/igb/igb_ptp.c
> index 5982f28d521a..c44df87c38de 100644
> --- a/drivers/net/ethernet/intel/igb/igb_ptp.c
> +++ b/drivers/net/ethernet/intel/igb/igb_ptp.c
> @@ -143,7 +143,7 @@ static void igb_ptp_write_i210(struct igb_adapter *adapter,
> * sub-nanosecond resolution.
> */
> wr32(E1000_SYSTIML, ts->tv_nsec);
> - wr32(E1000_SYSTIMH, ts->tv_sec);
> + wr32(E1000_SYSTIMH, (u32)ts->tv_sec);
This cast is unnecessary, because wr32 is writel, and that parameter
is a u32.
Thanks,
Richard
> }
>
> /**
next prev parent reply other threads:[~2015-10-01 19:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-30 11:26 [Intel-wired-lan] [PATCH 00/12] net: assorted y2038 changes Arnd Bergmann
2015-09-30 11:26 ` [Intel-wired-lan] [PATCH 03/12] net: igb: avoid using timespec Arnd Bergmann
2015-10-01 19:17 ` Richard Cochran [this message]
2015-10-01 20:01 ` Arnd Bergmann
2015-10-02 7:47 ` Richard Cochran
2015-10-05 10:17 ` [Intel-wired-lan] [PATCH 00/12] net: assorted y2038 changes David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151001191745.GC1872@localhost.localdomain \
--to=richardcochran@gmail.com \
--cc=intel-wired-lan@osuosl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox