* [Intel-wired-lan] [patch] i40e: fix an uninitialized variable bug
@ 2016-05-05 13:18 Dan Carpenter
2016-05-09 17:43 ` Bowers, AndrewX
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2016-05-05 13:18 UTC (permalink / raw)
To: intel-wired-lan
We removed this initialization but it is required. Let's put it back.
Fixes: 895106a577c4 ('i40e: trivial fixes')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/net/ethernet/intel/i40e/i40e_hmc.c b/drivers/net/ethernet/intel/i40e/i40e_hmc.c
index 5ebe12d..a7c7b1d 100644
--- a/drivers/net/ethernet/intel/i40e/i40e_hmc.c
+++ b/drivers/net/ethernet/intel/i40e/i40e_hmc.c
@@ -49,7 +49,7 @@ i40e_status i40e_add_sd_table_entry(struct i40e_hw *hw,
struct i40e_hmc_sd_entry *sd_entry;
bool dma_mem_alloc_done = false;
struct i40e_dma_mem mem;
- i40e_status ret_code;
+ i40e_status ret_code = I40E_SUCCESS;
u64 alloc_len;
if (NULL == hmc_info->sd_table.sd_entry) {
^ permalink raw reply related [flat|nested] 2+ messages in thread* [Intel-wired-lan] [patch] i40e: fix an uninitialized variable bug
2016-05-05 13:18 [Intel-wired-lan] [patch] i40e: fix an uninitialized variable bug Dan Carpenter
@ 2016-05-09 17:43 ` Bowers, AndrewX
0 siblings, 0 replies; 2+ messages in thread
From: Bowers, AndrewX @ 2016-05-09 17:43 UTC (permalink / raw)
To: intel-wired-lan
> -----Original Message-----
> From: Intel-wired-lan [mailto:intel-wired-lan-bounces at lists.osuosl.org] On
> Behalf Of Dan Carpenter
> Sent: Thursday, May 05, 2016 6:18 AM
> To: Kirsher, Jeffrey T <jeffrey.t.kirsher@intel.com>; Brandeburg, Jesse
> <jesse.brandeburg@intel.com>
> Cc: kernel-janitors at vger.kernel.org; linux-kernel at vger.kernel.org; intel-
> wired-lan at lists.osuosl.org; netdev at vger.kernel.org
> Subject: [Intel-wired-lan] [patch] i40e: fix an uninitialized variable bug
>
> We removed this initialization but it is required. Let's put it back.
>
> Fixes: 895106a577c4 ('i40e: trivial fixes')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Tested-by: Andrew Bowers <andrewx.bowers@intel.com>
No uninitialized variable warning at compile
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-05-09 17:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-05-05 13:18 [Intel-wired-lan] [patch] i40e: fix an uninitialized variable bug Dan Carpenter
2016-05-09 17:43 ` Bowers, AndrewX
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox