* [Intel-wired-lan] [jkirsher/net-queue PATCH] i40e: Fix incorrect use of tx_itr_setting when checking for Rx ITR setup
@ 2017-10-20 20:59 Alexander Duyck
2017-10-25 19:44 ` Bowers, AndrewX
0 siblings, 1 reply; 2+ messages in thread
From: Alexander Duyck @ 2017-10-20 20:59 UTC (permalink / raw)
To: intel-wired-lan
From: Alexander Duyck <alexander.h.duyck@intel.com>
It looks like there was either a copy/paste error or just a typo that
resulted in the Tx ITR setting being used to determine if we were using
adaptive Rx interrupt moderation or not.
This patch fixes the typo.
Fixes: 65e87c0398f5 ("i40evf: support queue-specific settings for interrupt moderation")
Signed-off-by: Alexander Duyck <alexander.h.duyck@intel.com>
---
drivers/net/ethernet/intel/i40e/i40e_txrx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/intel/i40e/i40e_txrx.c b/drivers/net/ethernet/intel/i40e/i40e_txrx.c
index edbc94c4353d..778633569663 100644
--- a/drivers/net/ethernet/intel/i40e/i40e_txrx.c
+++ b/drivers/net/ethernet/intel/i40e/i40e_txrx.c
@@ -2277,7 +2277,7 @@ static inline void i40e_update_enable_itr(struct i40e_vsi *vsi,
goto enable_int;
}
- if (ITR_IS_DYNAMIC(tx_itr_setting)) {
+ if (ITR_IS_DYNAMIC(rx_itr_setting)) {
rx = i40e_set_new_dynamic_itr(&q_vector->rx);
rxval = i40e_buildreg_itr(I40E_RX_ITR, q_vector->rx.itr);
}
^ permalink raw reply related [flat|nested] 2+ messages in thread* [Intel-wired-lan] [jkirsher/net-queue PATCH] i40e: Fix incorrect use of tx_itr_setting when checking for Rx ITR setup
2017-10-20 20:59 [Intel-wired-lan] [jkirsher/net-queue PATCH] i40e: Fix incorrect use of tx_itr_setting when checking for Rx ITR setup Alexander Duyck
@ 2017-10-25 19:44 ` Bowers, AndrewX
0 siblings, 0 replies; 2+ messages in thread
From: Bowers, AndrewX @ 2017-10-25 19:44 UTC (permalink / raw)
To: intel-wired-lan
> -----Original Message-----
> From: Intel-wired-lan [mailto:intel-wired-lan-bounces at osuosl.org] On
> Behalf Of Alexander Duyck
> Sent: Friday, October 20, 2017 1:59 PM
> To: intel-wired-lan at lists.osuosl.org
> Subject: [Intel-wired-lan] [jkirsher/net-queue PATCH] i40e: Fix incorrect use
> of tx_itr_setting when checking for Rx ITR setup
>
> From: Alexander Duyck <alexander.h.duyck@intel.com>
>
> It looks like there was either a copy/paste error or just a typo that resulted in
> the Tx ITR setting being used to determine if we were using adaptive Rx
> interrupt moderation or not.
>
> This patch fixes the typo.
>
> Fixes: 65e87c0398f5 ("i40evf: support queue-specific settings for interrupt
> moderation")
> Signed-off-by: Alexander Duyck <alexander.h.duyck@intel.com>
> ---
> drivers/net/ethernet/intel/i40e/i40e_txrx.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Tested-by: Andrew Bowers <andrewx.bowers@intel.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-10-25 19:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-10-20 20:59 [Intel-wired-lan] [jkirsher/net-queue PATCH] i40e: Fix incorrect use of tx_itr_setting when checking for Rx ITR setup Alexander Duyck
2017-10-25 19:44 ` Bowers, AndrewX
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox