* [Intel-wired-lan] [PATCH v3 14/17] fm10k: no need to check return value of debugfs_create functions
[not found] <20190810101732.26612-1-gregkh@linuxfoundation.org>
@ 2019-08-10 10:17 ` Greg Kroah-Hartman
2019-08-12 15:46 ` Jeff Kirsher
2019-08-10 10:17 ` [Intel-wired-lan] [PATCH v3 15/17] i40e: " Greg Kroah-Hartman
2019-08-10 10:17 ` [Intel-wired-lan] [PATCH v3 16/17] ixgbe: " Greg Kroah-Hartman
2 siblings, 1 reply; 6+ messages in thread
From: Greg Kroah-Hartman @ 2019-08-10 10:17 UTC (permalink / raw)
To: intel-wired-lan
When calling debugfs functions, there is no need to ever check the
return value. The function can work or not, but the code logic should
never do something different based on this.
Cc: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: intel-wired-lan at lists.osuosl.org
Cc: netdev at vger.kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
drivers/net/ethernet/intel/fm10k/fm10k_debugfs.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/net/ethernet/intel/fm10k/fm10k_debugfs.c b/drivers/net/ethernet/intel/fm10k/fm10k_debugfs.c
index dca104121c05..1d27b2fb23af 100644
--- a/drivers/net/ethernet/intel/fm10k/fm10k_debugfs.c
+++ b/drivers/net/ethernet/intel/fm10k/fm10k_debugfs.c
@@ -160,8 +160,6 @@ void fm10k_dbg_q_vector_init(struct fm10k_q_vector *q_vector)
snprintf(name, sizeof(name), "q_vector.%03d", q_vector->v_idx);
q_vector->dbg_q_vector = debugfs_create_dir(name, interface->dbg_intfc);
- if (!q_vector->dbg_q_vector)
- return;
/* Generate a file for each rx ring in the q_vector */
for (i = 0; i < q_vector->tx.count; i++) {
--
2.22.0
^ permalink raw reply related [flat|nested] 6+ messages in thread* [Intel-wired-lan] [PATCH v3 15/17] i40e: no need to check return value of debugfs_create functions
[not found] <20190810101732.26612-1-gregkh@linuxfoundation.org>
2019-08-10 10:17 ` [Intel-wired-lan] [PATCH v3 14/17] fm10k: no need to check return value of debugfs_create functions Greg Kroah-Hartman
@ 2019-08-10 10:17 ` Greg Kroah-Hartman
2019-08-12 15:48 ` Jeff Kirsher
2019-08-10 10:17 ` [Intel-wired-lan] [PATCH v3 16/17] ixgbe: " Greg Kroah-Hartman
2 siblings, 1 reply; 6+ messages in thread
From: Greg Kroah-Hartman @ 2019-08-10 10:17 UTC (permalink / raw)
To: intel-wired-lan
When calling debugfs functions, there is no need to ever check the
return value. The function can work or not, but the code logic should
never do something different based on this.
Cc: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: intel-wired-lan at lists.osuosl.org
Cc: netdev at vger.kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
.../net/ethernet/intel/i40e/i40e_debugfs.c | 22 ++++---------------
1 file changed, 4 insertions(+), 18 deletions(-)
diff --git a/drivers/net/ethernet/intel/i40e/i40e_debugfs.c b/drivers/net/ethernet/intel/i40e/i40e_debugfs.c
index 55d20acfcf70..41232898d8ae 100644
--- a/drivers/net/ethernet/intel/i40e/i40e_debugfs.c
+++ b/drivers/net/ethernet/intel/i40e/i40e_debugfs.c
@@ -1732,29 +1732,15 @@ static const struct file_operations i40e_dbg_netdev_ops_fops = {
**/
void i40e_dbg_pf_init(struct i40e_pf *pf)
{
- struct dentry *pfile;
const char *name = pci_name(pf->pdev);
- const struct device *dev = &pf->pdev->dev;
pf->i40e_dbg_pf = debugfs_create_dir(name, i40e_dbg_root);
- if (!pf->i40e_dbg_pf)
- return;
-
- pfile = debugfs_create_file("command", 0600, pf->i40e_dbg_pf, pf,
- &i40e_dbg_command_fops);
- if (!pfile)
- goto create_failed;
- pfile = debugfs_create_file("netdev_ops", 0600, pf->i40e_dbg_pf, pf,
- &i40e_dbg_netdev_ops_fops);
- if (!pfile)
- goto create_failed;
+ debugfs_create_file("command", 0600, pf->i40e_dbg_pf, pf,
+ &i40e_dbg_command_fops);
- return;
-
-create_failed:
- dev_info(dev, "debugfs dir/file for %s failed\n", name);
- debugfs_remove_recursive(pf->i40e_dbg_pf);
+ debugfs_create_file("netdev_ops", 0600, pf->i40e_dbg_pf, pf,
+ &i40e_dbg_netdev_ops_fops);
}
/**
--
2.22.0
^ permalink raw reply related [flat|nested] 6+ messages in thread* [Intel-wired-lan] [PATCH v3 15/17] i40e: no need to check return value of debugfs_create functions
2019-08-10 10:17 ` [Intel-wired-lan] [PATCH v3 15/17] i40e: " Greg Kroah-Hartman
@ 2019-08-12 15:48 ` Jeff Kirsher
0 siblings, 0 replies; 6+ messages in thread
From: Jeff Kirsher @ 2019-08-12 15:48 UTC (permalink / raw)
To: intel-wired-lan
On Sat, 2019-08-10 at 12:17 +0200, Greg Kroah-Hartman wrote:
> When calling debugfs functions, there is no need to ever check the
> return value. The function can work or not, but the code logic
> should
> never do something different based on this.
>
> Cc: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: intel-wired-lan at lists.osuosl.org
> Cc: netdev at vger.kernel.org
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Acked-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
> ---
> .../net/ethernet/intel/i40e/i40e_debugfs.c | 22 ++++-------------
> --
> 1 file changed, 4 insertions(+), 18 deletions(-)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: This is a digitally signed message part
URL: <http://lists.osuosl.org/pipermail/intel-wired-lan/attachments/20190812/68f7c23f/attachment.asc>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Intel-wired-lan] [PATCH v3 16/17] ixgbe: no need to check return value of debugfs_create functions
[not found] <20190810101732.26612-1-gregkh@linuxfoundation.org>
2019-08-10 10:17 ` [Intel-wired-lan] [PATCH v3 14/17] fm10k: no need to check return value of debugfs_create functions Greg Kroah-Hartman
2019-08-10 10:17 ` [Intel-wired-lan] [PATCH v3 15/17] i40e: " Greg Kroah-Hartman
@ 2019-08-10 10:17 ` Greg Kroah-Hartman
2019-08-12 15:49 ` Jeff Kirsher
2 siblings, 1 reply; 6+ messages in thread
From: Greg Kroah-Hartman @ 2019-08-10 10:17 UTC (permalink / raw)
To: intel-wired-lan
When calling debugfs functions, there is no need to ever check the
return value. The function can work or not, but the code logic should
never do something different based on this.
Cc: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: intel-wired-lan at lists.osuosl.org
Cc: netdev at vger.kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
.../net/ethernet/intel/ixgbe/ixgbe_debugfs.c | 22 +++++--------------
1 file changed, 5 insertions(+), 17 deletions(-)
diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_debugfs.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_debugfs.c
index 50dfb02fa34c..171cdc552961 100644
--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_debugfs.c
+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_debugfs.c
@@ -190,22 +190,12 @@ static const struct file_operations ixgbe_dbg_netdev_ops_fops = {
void ixgbe_dbg_adapter_init(struct ixgbe_adapter *adapter)
{
const char *name = pci_name(adapter->pdev);
- struct dentry *pfile;
+
adapter->ixgbe_dbg_adapter = debugfs_create_dir(name, ixgbe_dbg_root);
- if (adapter->ixgbe_dbg_adapter) {
- pfile = debugfs_create_file("reg_ops", 0600,
- adapter->ixgbe_dbg_adapter, adapter,
- &ixgbe_dbg_reg_ops_fops);
- if (!pfile)
- e_dev_err("debugfs reg_ops for %s failed\n", name);
- pfile = debugfs_create_file("netdev_ops", 0600,
- adapter->ixgbe_dbg_adapter, adapter,
- &ixgbe_dbg_netdev_ops_fops);
- if (!pfile)
- e_dev_err("debugfs netdev_ops for %s failed\n", name);
- } else {
- e_dev_err("debugfs entry for %s failed\n", name);
- }
+ debugfs_create_file("reg_ops", 0600, adapter->ixgbe_dbg_adapter,
+ adapter, &ixgbe_dbg_reg_ops_fops);
+ debugfs_create_file("netdev_ops", 0600, adapter->ixgbe_dbg_adapter,
+ adapter, &ixgbe_dbg_netdev_ops_fops);
}
/**
@@ -224,8 +214,6 @@ void ixgbe_dbg_adapter_exit(struct ixgbe_adapter *adapter)
void ixgbe_dbg_init(void)
{
ixgbe_dbg_root = debugfs_create_dir(ixgbe_driver_name, NULL);
- if (ixgbe_dbg_root == NULL)
- pr_err("init of debugfs failed\n");
}
/**
--
2.22.0
^ permalink raw reply related [flat|nested] 6+ messages in thread* [Intel-wired-lan] [PATCH v3 16/17] ixgbe: no need to check return value of debugfs_create functions
2019-08-10 10:17 ` [Intel-wired-lan] [PATCH v3 16/17] ixgbe: " Greg Kroah-Hartman
@ 2019-08-12 15:49 ` Jeff Kirsher
0 siblings, 0 replies; 6+ messages in thread
From: Jeff Kirsher @ 2019-08-12 15:49 UTC (permalink / raw)
To: intel-wired-lan
On Sat, 2019-08-10 at 12:17 +0200, Greg Kroah-Hartman wrote:
> When calling debugfs functions, there is no need to ever check the
> return value. The function can work or not, but the code logic
> should
> never do something different based on this.
>
> Cc: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: intel-wired-lan at lists.osuosl.org
> Cc: netdev at vger.kernel.org
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Acked-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
> ---
> .../net/ethernet/intel/ixgbe/ixgbe_debugfs.c | 22 +++++----------
> ----
> 1 file changed, 5 insertions(+), 17 deletions(-)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: This is a digitally signed message part
URL: <http://lists.osuosl.org/pipermail/intel-wired-lan/attachments/20190812/1c48e716/attachment.asc>
^ permalink raw reply [flat|nested] 6+ messages in thread