From: Jesse Brandeburg <jesse.brandeburg@intel.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [PATCH net v2] i40e/iavf: use better trace path
Date: Thu, 2 Jan 2020 18:23:42 -0800 [thread overview]
Message-ID: <20200103022342.820175-1-jesse.brandeburg@intel.com> (raw)
I'm seeing compilation fail of the i40e/iavf driver for some reason.
I just checked 5.5-rc4 and the tip of net/net-next and all fail.
Fails all the way back to v5.1 at least, I didn't check further back.
repro steps:
$ gcc -v
gcc version 9.2.1 20190827 (Red Hat 9.2.1-1) (GCC)
$ git checkout -b my-net davem-net/master
$ make mrproper
$ make O=../my-net.obj defconfig allmodconfig modules_prepare
$ make O=../my-net.obj M=drivers/net/ethernet/intel/i40e
make[1]: Entering directory '/home/jbrandeb/git/my-net.obj'
CC [M] drivers/net/ethernet/intel/i40e/i40e_main.o
In file included from
/home/jbrandeb/git/linux2/drivers/net/ethernet/intel/i40e/i40e_trace.h:209,
from /home/jbrandeb/git/linux2/drivers/net/ethernet/intel/i40e/i40e_main.c:20:
/home/jbrandeb/git/linux2/include/trace/define_trace.h:95:42: fatal error: ./i40e_trace.h: No such file or directory
95 | #include TRACE_INCLUDE(TRACE_INCLUDE_FILE)
| ^
compilation terminated.
make[2]: *** [/home/jbrandeb/git/linux2/scripts/Makefile.build:266: drivers/net/ethernet/intel/i40e/i40e_main.o] Error 1
make[1]: *** [/home/jbrandeb/git/linux2/Makefile:1693: drivers/net/ethernet/intel/i40e] Error 2
make[1]: Leaving directory '/home/jbrandeb/git/my-net.obj'
make: *** [Makefile:179: sub-make] Error 2
Just for sanity, I tried building the ice driver the same as above and
it succeeds, so the build does work for some drivers.
So fix the include path for the i40e driver trace file to be relative
to the kernel root like (some) other drivers do.
Signed-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
---
v2: added iavf for the same fix
---
drivers/net/ethernet/intel/i40e/i40e_trace.h | 2 +-
drivers/net/ethernet/intel/iavf/iavf_trace.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/intel/i40e/i40e_trace.h b/drivers/net/ethernet/intel/i40e/i40e_trace.h
index 424f02077e2e..122a3fcb62b1 100644
--- a/drivers/net/ethernet/intel/i40e/i40e_trace.h
+++ b/drivers/net/ethernet/intel/i40e/i40e_trace.h
@@ -203,7 +203,7 @@ DEFINE_EVENT(
* module.
*/
#undef TRACE_INCLUDE_PATH
-#define TRACE_INCLUDE_PATH .
+#define TRACE_INCLUDE_PATH ../../drivers/net/ethernet/intel/i40e
#undef TRACE_INCLUDE_FILE
#define TRACE_INCLUDE_FILE i40e_trace
#include <trace/define_trace.h>
diff --git a/drivers/net/ethernet/intel/iavf/iavf_trace.h b/drivers/net/ethernet/intel/iavf/iavf_trace.h
index 1058e68a02b4..b2674c935c21 100644
--- a/drivers/net/ethernet/intel/iavf/iavf_trace.h
+++ b/drivers/net/ethernet/intel/iavf/iavf_trace.h
@@ -203,7 +203,7 @@ DEFINE_EVENT(
* module.
*/
#undef TRACE_INCLUDE_PATH
-#define TRACE_INCLUDE_PATH .
+#define TRACE_INCLUDE_PATH ../../drivers/net/ethernet/intel/iavf
#undef TRACE_INCLUDE_FILE
#define TRACE_INCLUDE_FILE iavf_trace
#include <trace/define_trace.h>
--
2.24.1
next reply other threads:[~2020-01-03 2:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-03 2:23 Jesse Brandeburg [this message]
2020-01-06 20:18 ` [Intel-wired-lan] [PATCH net v2] i40e/iavf: use better trace path Bowers, AndrewX
2020-01-08 22:49 ` Jacob Keller
2020-01-08 22:55 ` Jacob Keller
2020-01-09 17:43 ` Jeff Kirsher
2020-01-10 6:47 ` Jesse Brandeburg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200103022342.820175-1-jesse.brandeburg@intel.com \
--to=jesse.brandeburg@intel.com \
--cc=intel-wired-lan@osuosl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox