From: Jesse Brandeburg <jesse.brandeburg@intel.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [PATCH net v2] i40e/iavf: use better trace path
Date: Thu, 9 Jan 2020 22:47:23 -0800 [thread overview]
Message-ID: <20200109224723.00003603@intel.com> (raw)
In-Reply-To: <9400163aa83bbd414e43e2aebd5d9e1e23e394b5.camel@intel.com>
On Thu, 9 Jan 2020 09:43:52 -0800 Jeff wrote:
> On Wed, 2020-01-08 at 14:55 -0800, Jacob Keller wrote:
> > On 1/8/2020 2:49 PM, Jacob Keller wrote:
> [...]
> [...]
> [...]
> [...]
> [...]
> >
> > It looks like this is handled in driver's Makefile via:
> >
> > ccflags-y += -I$(src)>-->------->-------# needed for trace events
> >
> > or the following:
> >
> > CFLAGS_trace.o := -I$(src)
>
> I like the above solution, as it is much cleaner and less prone for
> future errors, if the directory patch would change for whatever reason.
Hi Jeff, please drop this patch, I found after bisecting and finding a
commit in January of 2019 that causes my issue, that if I just change
the command sequence I do, everything works fine.
FAIL: make O=../foo.obj M=drivers/net/ethernet/intel/i40e
PASS: make O=../foo.obj M=`pwd`/drivers/net/ethernet/intel/i40e
So the change in behavior is somewhat introduced recently (a year ago)
but me just having to learn a new trick is better than trying to fix
this in the kernel.
Jesse
prev parent reply other threads:[~2020-01-10 6:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-03 2:23 [Intel-wired-lan] [PATCH net v2] i40e/iavf: use better trace path Jesse Brandeburg
2020-01-06 20:18 ` Bowers, AndrewX
2020-01-08 22:49 ` Jacob Keller
2020-01-08 22:55 ` Jacob Keller
2020-01-09 17:43 ` Jeff Kirsher
2020-01-10 6:47 ` Jesse Brandeburg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200109224723.00003603@intel.com \
--to=jesse.brandeburg@intel.com \
--cc=intel-wired-lan@osuosl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox