From: Jiri Pirko <jiri@resnulli.us>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [PATCH 3/4] devlink: add support for triggering snapshots from userspace
Date: Thu, 9 Jan 2020 19:58:43 +0100 [thread overview]
Message-ID: <20200109185843.GI2235@nanopsycho.orion> (raw)
In-Reply-To: <aace193a-066b-ef8d-72a0-7489ba989d87@intel.com>
Thu, Jan 09, 2020 at 07:50:23PM CET, jacob.e.keller at intel.com wrote:
>On 1/8/2020 11:05 PM, Jiri Pirko wrote:
>> Thu, Jan 09, 2020 at 02:08:18AM CET, jacob.e.keller at intel.com wrote:
>>> At region creation time, drivers may optionally define
>>> a trigger_snapshot function callback. If not defined, the
>>> DEVLINK_CMD_REGION_TRIGGER_SNAPSHOT will simply report EOPNOTSUPP.
>>
>> Similar mechanism is already implemented for health reporters. Why that
>> wouln't work for you?
>>
>
>Mostly, I didn't feel that the necessary information (flash contents)
>really made sense as a health report. The intent is to enable diagnostic
>tools to read the contents of the flash on a device.
I see.
>
>I'm fine using the health interface but in this case features like
>recovery method, etc do not make sense at all as it would not be
>triggered in response to error conditions.
Okay. Perhaps this is a usecase to have the regions.
Anyway, this patch does like 5 things in one. Please split it in
multiple patches, each doing one thing.
Thanks!
>
>Thanks,
>Jake
next prev parent reply other threads:[~2020-01-09 18:58 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-09 1:08 [Intel-wired-lan] [PATCH 0/4] devlink region snapshot triggering Jacob Keller
2020-01-09 1:08 ` [Intel-wired-lan] [PATCH 1/4] devlink: correct misspelling of snapshot Jacob Keller
2020-01-09 1:08 ` [Intel-wired-lan] [PATCH 2/4] doc: fix typo of snapshot in documentation Jacob Keller
2020-01-09 7:01 ` Jiri Pirko
2020-01-09 1:08 ` [Intel-wired-lan] [PATCH 3/4] devlink: add support for triggering snapshots from userspace Jacob Keller
2020-01-09 7:05 ` Jiri Pirko
2020-01-09 18:50 ` Jacob Keller
2020-01-09 18:58 ` Jiri Pirko [this message]
2020-01-09 19:07 ` Jacob Keller
2020-01-09 19:35 ` Jacob Keller
2020-01-09 1:08 ` [Intel-wired-lan] [PATCH 4/4] devlink: add support for DEVLINK_CMD_REGION_TRIGGER_SNAPSHOT Jacob Keller
2020-01-09 7:00 ` [Intel-wired-lan] [PATCH 0/4] devlink region snapshot triggering Jiri Pirko
2020-01-09 18:48 ` Jacob Keller
2020-01-09 18:59 ` Jiri Pirko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200109185843.GI2235@nanopsycho.orion \
--to=jiri@resnulli.us \
--cc=intel-wired-lan@osuosl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox