[Intel-wired-lan] [PATCH 3/4] devlink: add support for triggering snapshots from userspace

[Jacob Keller <jacob.e.keller@intel.com>]

On 1/9/2020 10:58 AM, Jiri Pirko wrote:
> Thu, Jan 09, 2020 at 07:50:23PM CET, jacob.e.keller at intel.com wrote:
>> On 1/8/2020 11:05 PM, Jiri Pirko wrote:
>>> Thu, Jan 09, 2020 at 02:08:18AM CET, jacob.e.keller at intel.com wrote:
>>>> At region creation time, drivers may optionally define
>>>> a trigger_snapshot function callback. If not defined, the
>>>> DEVLINK_CMD_REGION_TRIGGER_SNAPSHOT will simply report EOPNOTSUPP.
>>>
>>> Similar mechanism is already implemented for health reporters. Why that
>>> wouln't work for you?
>>>
>>
>> Mostly, I didn't feel that the necessary information (flash contents)
>> really made sense as a health report. The intent is to enable diagnostic
>> tools to read the contents of the flash on a device.
> 
> I see.
> 
>>
>> I'm fine using the health interface but in this case features like
>> recovery method, etc do not make sense at all as it would not be
>> triggered in response to error conditions.
> 
> Okay. Perhaps this is a usecase to have the regions.
> 
> Anyway, this patch does like 5 things in one. Please split it in
> multiple patches, each doing one thing.
> 
> Thanks!

I can split it into parts and expand on the reasoning for not using the
health interface.

Thanks,
Jake