[Intel-wired-lan] [PATCH] igc: Fix default MAC address filter override

[Intel-wired-lan] [PATCH] igc: Fix default MAC address filter override

[Andre Guedes]

This patch fixes a bug when the user adds the first MAC address filter
via ethtool NFC mechanism.

When the first MAC address filter is added, it overwrites the default
MAC address filter configured at RAL[0] and RAH[0]. As consequence,
frames addressed to the interface MAC address are not sent to host
anymore.

This patch fixes the bug by calling igc_set_default_mac_filter() during
adapter init so the position 0 of adapter->mac_table[] is assigned to
the default MAC address.

Signed-off-by: Andre Guedes <andre.guedes@intel.com>
---
 drivers/net/ethernet/intel/igc/igc_main.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/net/ethernet/intel/igc/igc_main.c b/drivers/net/ethernet/intel/igc/igc_main.c
index 025f2e439aef..3ddea16ec1da 100644
--- a/drivers/net/ethernet/intel/igc/igc_main.c
+++ b/drivers/net/ethernet/intel/igc/igc_main.c
@@ -2350,7 +2350,9 @@ static void igc_configure(struct igc_adapter *adapter)
 	igc_setup_mrqc(adapter);
 	igc_setup_rctl(adapter);
 
+	igc_set_default_mac_filter(adapter);
 	igc_nfc_filter_restore(adapter);
+
 	igc_configure_tx(adapter);
 	igc_configure_rx(adapter);
 
-- 
2.25.0

[Intel-wired-lan] [PATCH] igc: Fix default MAC address filter override

[Brown, Aaron F]

> From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of
> Andre Guedes
> Sent: Monday, March 9, 2020 4:11 PM
> To: intel-wired-lan at lists.osuosl.org
> Subject: [Intel-wired-lan] [PATCH] igc: Fix default MAC address filter override
> 
> This patch fixes a bug when the user adds the first MAC address filter
> via ethtool NFC mechanism.
> 
> When the first MAC address filter is added, it overwrites the default
> MAC address filter configured at RAL[0] and RAH[0]. As consequence,
> frames addressed to the interface MAC address are not sent to host
> anymore.
> 
> This patch fixes the bug by calling igc_set_default_mac_filter() during
> adapter init so the position 0 of adapter->mac_table[] is assigned to
> the default MAC address.
> 
> Signed-off-by: Andre Guedes <andre.guedes@intel.com>
> ---
>  drivers/net/ethernet/intel/igc/igc_main.c | 2 ++
>  1 file changed, 2 insertions(+)
Tested-by: Aaron Brown <aaron.f.brown@intel.com>