From: Alexander Lobakin <alobakin@pm.me>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [PATCH RESEND v3 net-next 3/5] net: introduce common dev_page_is_reusable()
Date: Tue, 02 Feb 2021 13:31:21 +0000 [thread overview]
Message-ID: <20210202133030.5760-4-alobakin@pm.me> (raw)
In-Reply-To: <20210202133030.5760-1-alobakin@pm.me>
A bunch of drivers test the page before reusing/recycling for two
common conditions:
- if a page was allocated under memory pressure (pfmemalloc page);
- if a page was allocated at a distant memory node (to exclude
slowdowns).
Introduce a new common inline for doing this, with likely() already
folded inside to make driver code a bit simpler.
Suggested-by: David Rientjes <rientjes@google.com>
Suggested-by: Jakub Kicinski <kuba@kernel.org>
Cc: John Hubbard <jhubbard@nvidia.com>
Signed-off-by: Alexander Lobakin <alobakin@pm.me>
Reviewed-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
Acked-by: David Rientjes <rientjes@google.com>
---
include/linux/skbuff.h | 16 ++++++++++++++++
1 file changed, 16 insertions(+)
diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h
index b027526da4f9..0e42c53b8ca9 100644
--- a/include/linux/skbuff.h
+++ b/include/linux/skbuff.h
@@ -2938,6 +2938,22 @@ static inline struct page *dev_alloc_page(void)
return dev_alloc_pages(0);
}
+/**
+ * dev_page_is_reusable - check whether a page can be reused for network Rx
+ * @page: the page to test
+ *
+ * A page shouldn't be considered for reusing/recycling if it was allocated
+ * under memory pressure or at a distant memory node.
+ *
+ * Returns false if this page should be returned to page allocator, true
+ * otherwise.
+ */
+static inline bool dev_page_is_reusable(const struct page *page)
+{
+ return likely(page_to_nid(page) == numa_mem_id() &&
+ !page_is_pfmemalloc(page));
+}
+
/**
* skb_propagate_pfmemalloc - Propagate pfmemalloc if skb is allocated after RX page
* @page: The page that was allocated from skb_alloc_page
--
2.30.0
next prev parent reply other threads:[~2021-02-02 13:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-02 13:30 [Intel-wired-lan] [PATCH RESEND v3 net-next 0/5] net: consolidate page_is_pfmemalloc() usage Alexander Lobakin
2021-02-02 13:30 ` [Intel-wired-lan] [PATCH RESEND v3 net-next 1/5] mm: constify page_is_pfmemalloc() argument Alexander Lobakin
2021-02-02 13:31 ` [Intel-wired-lan] [PATCH RESEND v3 net-next 2/5] skbuff: constify skb_propagate_pfmemalloc() "page" argument Alexander Lobakin
2021-02-02 13:31 ` Alexander Lobakin [this message]
2021-02-02 13:31 ` [Intel-wired-lan] [PATCH RESEND v3 net-next 4/5] net: use the new dev_page_is_reusable() instead of private versions Alexander Lobakin
2021-02-04 19:52 ` Jesse Brandeburg
2021-02-02 13:31 ` [Intel-wired-lan] [PATCH RESEND v3 net-next 5/5] net: page_pool: simplify page recycling condition tests Alexander Lobakin
2021-02-05 2:40 ` [Intel-wired-lan] [PATCH RESEND v3 net-next 0/5] net: consolidate page_is_pfmemalloc() usage patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210202133030.5760-4-alobakin@pm.me \
--to=alobakin@pm.me \
--cc=intel-wired-lan@osuosl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox