From: Muhammad Husaini Zulkifli <muhammad.husaini.zulkifli@intel.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [PATCH net v1 1/2] igc: Fix Pause Frame Advertising
Date: Sat, 20 Feb 2021 00:36:47 +0800 [thread overview]
Message-ID: <20210219163648.14581-2-muhammad.husaini.zulkifli@intel.com> (raw)
In-Reply-To: <20210219163648.14581-1-muhammad.husaini.zulkifli@intel.com>
Fix Pause Frame Advertising when getting the advertisement via ethtool.
Remove setting the "advertising" bit in link_ksettings during default
case when tx and rx are in off state with Auto Negotiatiate off.
Below is the original output of advertisement link during tx and rx off:
Advertised pause frame use: Symmetric Receive-only
Expected output:
Advertised pause frame use: No
Fixes: 8c5ad0dae93c ("igc: Add ethtool support")
Signed-off-by: Muhammad Husaini Zulkifli <muhammad.husaini.zulkifli@intel.com>
Reviewed-by: Malli C <mallikarjuna.chilakala@intel.com>
---
drivers/net/ethernet/intel/igc/igc_ethtool.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/net/ethernet/intel/igc/igc_ethtool.c b/drivers/net/ethernet/intel/igc/igc_ethtool.c
index 824a6c454bca..67a4aed45fc2 100644
--- a/drivers/net/ethernet/intel/igc/igc_ethtool.c
+++ b/drivers/net/ethernet/intel/igc/igc_ethtool.c
@@ -1725,9 +1725,7 @@ static int igc_ethtool_get_link_ksettings(struct net_device *netdev,
Asym_Pause);
break;
default:
- ethtool_link_ksettings_add_link_mode(cmd, advertising, Pause);
- ethtool_link_ksettings_add_link_mode(cmd, advertising,
- Asym_Pause);
+ break;
}
status = pm_runtime_suspended(&adapter->pdev->dev) ?
--
2.17.1
next prev parent reply other threads:[~2021-02-19 16:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-19 16:36 [Intel-wired-lan] [PATCH net v1 0/2] igc: Fix Pause Frame Advertising Muhammad Husaini Zulkifli
2021-02-19 16:36 ` Muhammad Husaini Zulkifli [this message]
2021-02-20 17:31 ` [Intel-wired-lan] [PATCH net v1 1/2] " Neftin, Sasha
2021-03-03 8:08 ` Dvora Fuxbrumer
2021-02-19 16:36 ` [Intel-wired-lan] [PATCH net v1 2/2] igc: Fix Supported Pause Frame Link Setting Muhammad Husaini Zulkifli
2021-03-03 8:09 ` Dvora Fuxbrumer
2021-03-03 9:26 ` Neftin, Sasha
2021-03-03 8:08 ` [Intel-wired-lan] [PATCH net v1 0/2] igc: Fix Pause Frame Advertising Dvora Fuxbrumer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210219163648.14581-2-muhammad.husaini.zulkifli@intel.com \
--to=muhammad.husaini.zulkifli@intel.com \
--cc=intel-wired-lan@osuosl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox