From: Neftin, Sasha <sasha.neftin@intel.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [PATCH net v1 2/2] igc: Fix Supported Pause Frame Link Setting
Date: Wed, 3 Mar 2021 11:26:52 +0200 [thread overview]
Message-ID: <81dc14b2-7aaf-9166-ab07-94e0b1e35224@intel.com> (raw)
In-Reply-To: <ec5adf63-63d7-7e8e-f260-3eaf29ac82c3@linux.intel.com>
On 3/3/2021 10:09, Dvora Fuxbrumer wrote:
> On 19/02/2021 18:36, Muhammad Husaini Zulkifli wrote:
>> The Supported Pause Frame always display "No" eventhough the Advertised
>> pause frame showing the correct setting based on the pause parameters via
>> ethtool. Set bit in link_ksettings to "Supported" for Pause Frame.
>>
>> Before output:
>> Supported pause frame use: No
>>
>> Expected output:
>> Supported pause frame use: Symmetric
>>
>> Fixes: 8c5ad0dae93c ("igc: Add ethtool support")
>> Signed-off-by: Muhammad Husaini Zulkifli
>> <muhammad.husaini.zulkifli@intel.com>
>> Reviewed-by: Malli C <mallikarjuna.chilakala@intel.com>
>> ---
>> ? drivers/net/ethernet/intel/igc/igc_ethtool.c | 3 +++
>> ? 1 file changed, 3 insertions(+)
>>
>> diff --git a/drivers/net/ethernet/intel/igc/igc_ethtool.c
>> b/drivers/net/ethernet/intel/igc/igc_ethtool.c
>> index 67a4aed45fc2..8722294ab90c 100644
>> --- a/drivers/net/ethernet/intel/igc/igc_ethtool.c
>> +++ b/drivers/net/ethernet/intel/igc/igc_ethtool.c
>> @@ -1711,6 +1711,9 @@ static int igc_ethtool_get_link_ksettings(struct
>> net_device *netdev,
>> ?????????????????????????????? Autoneg);
>> ????? }
>> +??? /* Set pause flow control settings */
>> +??? ethtool_link_ksettings_add_link_mode(cmd, supported, Pause);
>> +
>> ????? switch (hw->fc.requested_mode) {
>> ????? case igc_fc_full:
>> ????????? ethtool_link_ksettings_add_link_mode(cmd, advertising, Pause);
>>
> Tested-by: Dvora Fuxbrumer <dvorax.fuxbrumer@linux.intel.com>
> _______________________________________________
> Intel-wired-lan mailing list
> Intel-wired-lan at osuosl.org
> https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
Acked-by: Sasha Neftin <sasha.neftin@intel.com>
next prev parent reply other threads:[~2021-03-03 9:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-19 16:36 [Intel-wired-lan] [PATCH net v1 0/2] igc: Fix Pause Frame Advertising Muhammad Husaini Zulkifli
2021-02-19 16:36 ` [Intel-wired-lan] [PATCH net v1 1/2] " Muhammad Husaini Zulkifli
2021-02-20 17:31 ` Neftin, Sasha
2021-03-03 8:08 ` Dvora Fuxbrumer
2021-02-19 16:36 ` [Intel-wired-lan] [PATCH net v1 2/2] igc: Fix Supported Pause Frame Link Setting Muhammad Husaini Zulkifli
2021-03-03 8:09 ` Dvora Fuxbrumer
2021-03-03 9:26 ` Neftin, Sasha [this message]
2021-03-03 8:08 ` [Intel-wired-lan] [PATCH net v1 0/2] igc: Fix Pause Frame Advertising Dvora Fuxbrumer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=81dc14b2-7aaf-9166-ab07-94e0b1e35224@intel.com \
--to=sasha.neftin@intel.com \
--cc=intel-wired-lan@osuosl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox