* [Intel-wired-lan] [PATCH net v1] i40e: Fix autoneg disabling for non-10GBaseT links
@ 2021-03-10 11:12 Mateusz Palczewski
2021-03-11 19:27 ` Nguyen, Anthony L
0 siblings, 1 reply; 2+ messages in thread
From: Mateusz Palczewski @ 2021-03-10 11:12 UTC (permalink / raw)
To: intel-wired-lan
Disabling autonegotiation was allowed only for 10GBaseT PHY.
The condition was changed to check if link media type is BaseT.
Fixes: 3ce12ee9d8f9("i40e: Fix order of checks when enabling/disabling autoneg in ethtool")
Reviewed-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com>
Reviewed-by: Karen Sornek <karen.sornek@intel.com>
Signed-off-by: Dawid Lukwinski <dawid.lukwinski@intel.com>
Signed-off-by: Mateusz Palczewski <mateusz.palczewski@intel.com>
---
drivers/net/ethernet/intel/i40e/i40e_ethtool.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/intel/i40e/i40e_ethtool.c b/drivers/net/ethernet/intel/i40e/i40e_ethtool.c
index 45f5dc2..9c1a0f7 100644
--- a/drivers/net/ethernet/intel/i40e/i40e_ethtool.c
+++ b/drivers/net/ethernet/intel/i40e/i40e_ethtool.c
@@ -1253,8 +1253,7 @@ static int i40e_set_link_ksettings(struct net_device *netdev,
if (ethtool_link_ksettings_test_link_mode(&safe_ks,
supported,
Autoneg) &&
- hw->phy.link_info.phy_type !=
- I40E_PHY_TYPE_10GBASE_T) {
+ hw->phy.media_type != I40E_MEDIA_TYPE_BASET) {
netdev_info(netdev, "Autoneg cannot be disabled on this phy\n");
err = -EINVAL;
goto done;
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [Intel-wired-lan] [PATCH net v1] i40e: Fix autoneg disabling for non-10GBaseT links
2021-03-10 11:12 [Intel-wired-lan] [PATCH net v1] i40e: Fix autoneg disabling for non-10GBaseT links Mateusz Palczewski
@ 2021-03-11 19:27 ` Nguyen, Anthony L
0 siblings, 0 replies; 2+ messages in thread
From: Nguyen, Anthony L @ 2021-03-11 19:27 UTC (permalink / raw)
To: intel-wired-lan
On Wed, 2021-03-10 at 11:12 +0000, Mateusz Palczewski wrote:
> Disabling autonegotiation was allowed only for 10GBaseT PHY.
> The condition was changed to check if link media type is BaseT.
>
> Fixes: 3ce12ee9d8f9("i40e: Fix order of checks when
> enabling/disabling autoneg in ethtool")
This is missing a space after the hash
> Reviewed-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com>
> Reviewed-by: Karen Sornek <karen.sornek@intel.com>
> Signed-off-by: Dawid Lukwinski <dawid.lukwinski@intel.com>
> Signed-off-by: Mateusz Palczewski <mateusz.palczewski@intel.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-03-11 19:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-03-10 11:12 [Intel-wired-lan] [PATCH net v1] i40e: Fix autoneg disabling for non-10GBaseT links Mateusz Palczewski
2021-03-11 19:27 ` Nguyen, Anthony L
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox