* [Intel-wired-lan] [PATCH v2 1/1] igc: Fix overwrites return value
@ 2021-03-24 8:05 Sasha Neftin
2021-04-11 7:03 ` Dvora Fuxbrumer
0 siblings, 1 reply; 2+ messages in thread
From: Sasha Neftin @ 2021-03-24 8:05 UTC (permalink / raw)
To: intel-wired-lan
drivers/net/ethernet/intel/igc/igc_i225.c:235 igc_write_nvm_srwr()
warn: loop overwrites return value 'ret_val'
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Sasha Neftin <sasha.neftin@intel.com>
---
drivers/net/ethernet/intel/igc/igc_i225.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/intel/igc/igc_i225.c b/drivers/net/ethernet/intel/igc/igc_i225.c
index cc83bb5c15e8..b2ef9fde97b3 100644
--- a/drivers/net/ethernet/intel/igc/igc_i225.c
+++ b/drivers/net/ethernet/intel/igc/igc_i225.c
@@ -229,10 +229,11 @@ static s32 igc_write_nvm_srwr(struct igc_hw *hw, u16 offset, u16 words,
if (offset >= nvm->word_size || (words > (nvm->word_size - offset)) ||
words == 0) {
hw_dbg("nvm parameter(s) out of bounds\n");
- goto out;
+ return ret_val;
}
for (i = 0; i < words; i++) {
+ ret_val = -IGC_ERR_NVM;
eewr = ((offset + i) << IGC_NVM_RW_ADDR_SHIFT) |
(data[i] << IGC_NVM_RW_REG_DATA) |
IGC_NVM_RW_REG_START;
@@ -254,7 +255,6 @@ static s32 igc_write_nvm_srwr(struct igc_hw *hw, u16 offset, u16 words,
}
}
-out:
return ret_val;
}
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [Intel-wired-lan] [PATCH v2 1/1] igc: Fix overwrites return value
2021-03-24 8:05 [Intel-wired-lan] [PATCH v2 1/1] igc: Fix overwrites return value Sasha Neftin
@ 2021-04-11 7:03 ` Dvora Fuxbrumer
0 siblings, 0 replies; 2+ messages in thread
From: Dvora Fuxbrumer @ 2021-04-11 7:03 UTC (permalink / raw)
To: intel-wired-lan
On 24/03/2021 10:05, Sasha Neftin wrote:
> drivers/net/ethernet/intel/igc/igc_i225.c:235 igc_write_nvm_srwr()
> warn: loop overwrites return value 'ret_val'
>
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> Signed-off-by: Sasha Neftin <sasha.neftin@intel.com>
> ---
> drivers/net/ethernet/intel/igc/igc_i225.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
Tested-by: Dvora Fuxbrumer <dvorax.fuxbrumer@linux.intel.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-04-11 7:03 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-03-24 8:05 [Intel-wired-lan] [PATCH v2 1/1] igc: Fix overwrites return value Sasha Neftin
2021-04-11 7:03 ` Dvora Fuxbrumer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox