Intel-Wired-Lan Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Arkadiusz Kubalewski <arkadiusz.kubalewski@intel.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [PATCH net] i40e: Fix sparse error: 'vsi->netdev' could be null
Date: Fri, 26 Mar 2021 19:43:42 +0100	[thread overview]
Message-ID: <20210326184343.133396-3-arkadiusz.kubalewski@intel.com> (raw)
In-Reply-To: <20210326184343.133396-1-arkadiusz.kubalewski@intel.com>

Remove vsi->netdev->name from the trace.
This is redundant information. With the devinfo trace, the adapter
is already identifiable.

Previously following error was produced when compiling against sparse.
i40e_main.c:2571 i40e_sync_vsi_filters() error:
	we previously assumed 'vsi->netdev' could be null (see line 2323)

Fixes: b603f9dc20af ("i40e: Log info when PF is entering and leaving Allmulti mode.")
Signed-off-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com>
Signed-off-by: Arkadiusz Kubalewski <arkadiusz.kubalewski@intel.com>
---
 drivers/net/ethernet/intel/i40e/i40e_main.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c
index d0feb47..2e9c22c 100644
--- a/drivers/net/ethernet/intel/i40e/i40e_main.c
+++ b/drivers/net/ethernet/intel/i40e/i40e_main.c
@@ -2568,8 +2568,7 @@ int i40e_sync_vsi_filters(struct i40e_vsi *vsi)
 				 i40e_stat_str(hw, aq_ret),
 				 i40e_aq_str(hw, hw->aq.asq_last_status));
 		} else {
-			dev_info(&pf->pdev->dev, "%s is %s allmulti mode.\n",
-				 vsi->netdev->name,
+			dev_info(&pf->pdev->dev, "%s allmulti mode.\n",
 				 cur_multipromisc ? "entering" : "leaving");
 		}
 	}

base-commit: ca4303103f33952646218db4e0869e6f6aa1c840
-- 
2.26.0


  parent reply	other threads:[~2021-03-26 18:43 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-26 18:43 [Intel-wired-lan] [PATCH net] i40e: Fix sparse errors in i40e_txrx.c Arkadiusz Kubalewski
2021-03-26 18:43 ` [Intel-wired-lan] [PATCH net] i40e: Fix sparse error: uninitialized symbol 'ring' Arkadiusz Kubalewski
2021-04-07 22:57   ` Switzer, David
2021-03-26 18:43 ` Arkadiusz Kubalewski [this message]
2021-04-07 22:55   ` [Intel-wired-lan] [PATCH net] i40e: Fix sparse error: 'vsi->netdev' could be null Switzer, David
2021-03-26 18:43 ` [Intel-wired-lan] [PATCH net] i40e: Fix sparse warning: missing error code 'err' Arkadiusz Kubalewski
2021-04-07 22:57   ` Switzer, David
2021-04-07 22:56 ` [Intel-wired-lan] [PATCH net] i40e: Fix sparse errors in i40e_txrx.c Switzer, David

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210326184343.133396-3-arkadiusz.kubalewski@intel.com \
    --to=arkadiusz.kubalewski@intel.com \
    --cc=intel-wired-lan@osuosl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox