Intel-Wired-Lan Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Arkadiusz Kubalewski <arkadiusz.kubalewski@intel.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [PATCH net] i40e: Fix sparse warning: missing error code 'err'
Date: Fri, 26 Mar 2021 19:43:43 +0100	[thread overview]
Message-ID: <20210326184343.133396-4-arkadiusz.kubalewski@intel.com> (raw)
In-Reply-To: <20210326184343.133396-1-arkadiusz.kubalewski@intel.com>

Set proper return values inside error checking if-statements.

Previously following warning was produced when compiling against sparse.
i40e_main.c:15162 i40e_init_recovery_mode() warn: missing error code 'err'

Fixes: 4ff0ee1af0169 ("i40e: Introduce recovery mode support")
Signed-off-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com>
Signed-off-by: Arkadiusz Kubalewski <arkadiusz.kubalewski@intel.com>
---
 drivers/net/ethernet/intel/i40e/i40e_main.c | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c
index 2e9c22c..73d0c01 100644
--- a/drivers/net/ethernet/intel/i40e/i40e_main.c
+++ b/drivers/net/ethernet/intel/i40e/i40e_main.c
@@ -15157,12 +15157,16 @@ static int i40e_init_recovery_mode(struct i40e_pf *pf, struct i40e_hw *hw)
 	 * in order to register the netdev
 	 */
 	v_idx = i40e_vsi_mem_alloc(pf, I40E_VSI_MAIN);
-	if (v_idx < 0)
+	if (v_idx < 0) {
+		err = v_idx;
 		goto err_switch_setup;
+	}
 	pf->lan_vsi = v_idx;
 	vsi = pf->vsi[v_idx];
-	if (!vsi)
+	if (!vsi) {
+		err = -EFAULT;
 		goto err_switch_setup;
+	}
 	vsi->alloc_queue_pairs = 1;
 	err = i40e_config_netdev(vsi);
 	if (err)

base-commit: ca4303103f33952646218db4e0869e6f6aa1c840
-- 
2.26.0


  parent reply	other threads:[~2021-03-26 18:43 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-26 18:43 [Intel-wired-lan] [PATCH net] i40e: Fix sparse errors in i40e_txrx.c Arkadiusz Kubalewski
2021-03-26 18:43 ` [Intel-wired-lan] [PATCH net] i40e: Fix sparse error: uninitialized symbol 'ring' Arkadiusz Kubalewski
2021-04-07 22:57   ` Switzer, David
2021-03-26 18:43 ` [Intel-wired-lan] [PATCH net] i40e: Fix sparse error: 'vsi->netdev' could be null Arkadiusz Kubalewski
2021-04-07 22:55   ` Switzer, David
2021-03-26 18:43 ` Arkadiusz Kubalewski [this message]
2021-04-07 22:57   ` [Intel-wired-lan] [PATCH net] i40e: Fix sparse warning: missing error code 'err' Switzer, David
2021-04-07 22:56 ` [Intel-wired-lan] [PATCH net] i40e: Fix sparse errors in i40e_txrx.c Switzer, David

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210326184343.133396-4-arkadiusz.kubalewski@intel.com \
    --to=arkadiusz.kubalewski@intel.com \
    --cc=intel-wired-lan@osuosl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox