[Intel-wired-lan] [PATCH net v2] i40e: fix the restart auto-negotiation after FEC modified

[Intel-wired-lan] [PATCH net v2] i40e: fix the restart auto-negotiation after FEC modified

[Mateusz Palczewski]

From: Jaroslaw Gawin <jaroslawx.gawin@intel.com>

When FEC mode was changed the link didn't know it because
the link was not reset and new parameters were not negotiated.
Set a flag 'I40E_AQ_PHY_ENABLE_ATOMIC_LINK' in 'abilities'
to restart the link and make it run with the new settings.

Fixes: 1d96340196f1 ("i40e: Add support FEC configuration for Fortville
25G")
Signed-off-by: Jaroslaw Gawin <jaroslawx.gawin@intel.com>
Signed-off-by: Mateusz Palczewski <mateusz.palczewski@intel.com>
---
 v2: Fixed fixes tag
---
 drivers/net/ethernet/intel/i40e/i40e_ethtool.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/intel/i40e/i40e_ethtool.c b/drivers/net/ethernet/intel/i40e/i40e_ethtool.c
index fe5befa..1ccf0dc 100644
--- a/drivers/net/ethernet/intel/i40e/i40e_ethtool.c
+++ b/drivers/net/ethernet/intel/i40e/i40e_ethtool.c
@@ -1409,7 +1409,8 @@ static int i40e_set_fec_cfg(struct net_device *netdev, u8 fec_cfg)
 
 		memset(&config, 0, sizeof(config));
 		config.phy_type = abilities.phy_type;
-		config.abilities = abilities.abilities;
+		config.abilities = abilities.abilities |
+				   I40E_AQ_PHY_ENABLE_ATOMIC_LINK;
 		config.phy_type_ext = abilities.phy_type_ext;
 		config.link_speed = abilities.link_speed;
 		config.eee_capability = abilities.eee_capability;
-- 
2.17.1

[Intel-wired-lan] [PATCH net v2] i40e: fix the restart auto-negotiation after FEC modified

[Nguyen, Anthony L]

On Tue, 2021-04-13 at 14:19 +0000, Mateusz Palczewski wrote:
> From: Jaroslaw Gawin <jaroslawx.gawin@intel.com>
> 
> When FEC mode was changed the link didn't know it because
> the link was not reset and new parameters were not negotiated.
> Set a flag 'I40E_AQ_PHY_ENABLE_ATOMIC_LINK' in 'abilities'
> to restart the link and make it run with the new settings.
> 
> Fixes: 1d96340196f1 ("i40e: Add support FEC configuration for
> Fortville
> 25G")

I've fixed this up but please note that the tag should not be wrapped.

"Do not split the tag across multiple lines, tags are exempt from the
wrap at 75 columns rule in order to simplify parsing scripts."

https://www.kernel.org/doc/html/latest/process/submitting-patches.html

> Signed-off-by: Jaroslaw Gawin <jaroslawx.gawin@intel.com>
> Signed-off-by: Mateusz Palczewski <mateusz.palczewski@intel.com>

[Intel-wired-lan] [PATCH net v2] i40e: fix the restart auto-negotiation after FEC modified

[Switzer, David]

>-----Original Message-----
>From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of
>Mateusz Palczewski
>Sent: Tuesday, April 13, 2021 7:20 AM
To: intel-wired-lan@lists.osuosl.org
>Cc: Gawin, JaroslawX <jaroslawx.gawin@intel.com>; Palczewski, Mateusz
><mateusz.palczewski@intel.com>
>Subject: [Intel-wired-lan] [PATCH net v2] i40e: fix the restart auto-negotiation
>after FEC modified
>
>From: Jaroslaw Gawin <jaroslawx.gawin@intel.com>
>
>When FEC mode was changed the link didn't know it because the link was not
>reset and new parameters were not negotiated.
>Set a flag 'I40E_AQ_PHY_ENABLE_ATOMIC_LINK' in 'abilities'
>to restart the link and make it run with the new settings.
>
>Fixes: 1d96340196f1 ("i40e: Add support FEC configuration for Fortville
>25G")
>Signed-off-by: Jaroslaw Gawin <jaroslawx.gawin@intel.com>
>Signed-off-by: Mateusz Palczewski <mateusz.palczewski@intel.com>
>---
> v2: Fixed fixes tag
>---
> drivers/net/ethernet/intel/i40e/i40e_ethtool.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
Tested-by: Dave Switzer <david.switzer@intel.com>