Intel-Wired-Lan Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Nitesh Narayan Lal <nitesh@redhat.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [PATCH v1 09/14] ixgbe: Use irq_update_affinity_hint
Date: Thu, 17 Jun 2021 14:22:37 -0400	[thread overview]
Message-ID: <20210617182242.8637-10-nitesh@redhat.com> (raw)
In-Reply-To: <20210617182242.8637-1-nitesh@redhat.com>

The driver uses irq_set_affinity_hint() to update the affinity_hint mask
that is consumed by the userspace to distribute the interrupts. However,
under the hood irq_set_affinity_hint() also applies the provided cpumask
(if not NULL) as the affinity for the given interrupt which is an
undocumented side effect.

To remove this side effect irq_set_affinity_hint() has been marked
as deprecated and new interfaces have been introduced. Hence, replace the
irq_set_affinity_hint() with the new interface irq_update_affinity_hint()
that only updates the affinity_hint pointer.

Signed-off-by: Nitesh Narayan Lal <nitesh@redhat.com>
---
 drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
index 2ac5b82676f3..b66040319bc6 100644
--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
@@ -3243,7 +3243,7 @@ static int ixgbe_request_msix_irqs(struct ixgbe_adapter *adapter)
 		/* If Flow Director is enabled, set interrupt affinity */
 		if (adapter->flags & IXGBE_FLAG_FDIR_HASH_CAPABLE) {
 			/* assign the mask for this irq */
-			irq_set_affinity_hint(entry->vector,
+			irq_update_affinity_hint(entry->vector,
 					      &q_vector->affinity_mask);
 		}
 	}
@@ -3260,7 +3260,7 @@ static int ixgbe_request_msix_irqs(struct ixgbe_adapter *adapter)
 free_queue_irqs:
 	while (vector) {
 		vector--;
-		irq_set_affinity_hint(adapter->msix_entries[vector].vector,
+		irq_update_affinity_hint(adapter->msix_entries[vector].vector,
 				      NULL);
 		free_irq(adapter->msix_entries[vector].vector,
 			 adapter->q_vector[vector]);
@@ -3394,7 +3394,7 @@ static void ixgbe_free_irq(struct ixgbe_adapter *adapter)
 			continue;
 
 		/* clear the affinity_mask in the IRQ descriptor */
-		irq_set_affinity_hint(entry->vector, NULL);
+		irq_update_affinity_hint(entry->vector, NULL);
 
 		free_irq(entry->vector, q_vector);
 	}
-- 
2.27.0


  parent reply	other threads:[~2021-06-17 18:22 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-17 18:22 [Intel-wired-lan] [PATCH v1 00/14] genirq: Cleanup the usage of irq_set_affinity_hint Nitesh Narayan Lal
2021-06-17 18:22 ` [Intel-wired-lan] [PATCH v1 01/14] genirq: Provide new interfaces for affinity hints Nitesh Narayan Lal
2021-06-25 17:52   ` Nitesh Lal
2021-06-17 18:22 ` [Intel-wired-lan] [PATCH v1 02/14] iavf: Use irq_update_affinity_hint Nitesh Narayan Lal
2021-06-17 18:22 ` [Intel-wired-lan] [PATCH v1 03/14] i40e: " Nitesh Narayan Lal
2021-06-17 18:22 ` [Intel-wired-lan] [PATCH v1 04/14] scsi: megaraid_sas: Use irq_set_affinity_and_hint Nitesh Narayan Lal
2021-06-17 19:31   ` Robin Murphy
2021-06-17 19:34     ` Nitesh Lal
2021-06-17 18:22 ` [Intel-wired-lan] [PATCH v1 05/14] scsi: mpt3sas: " Nitesh Narayan Lal
2021-06-17 18:22 ` [Intel-wired-lan] [PATCH v1 06/14] RDMA/i40iw: Use irq_update_affinity_hint Nitesh Narayan Lal
2021-06-17 18:22 ` [Intel-wired-lan] [PATCH v1 07/14] enic: " Nitesh Narayan Lal
2021-06-17 18:22 ` [Intel-wired-lan] [PATCH v1 08/14] be2net: " Nitesh Narayan Lal
2021-06-17 18:22 ` Nitesh Narayan Lal [this message]
2021-06-17 18:22 ` [Intel-wired-lan] [PATCH v1 10/14] mailbox: " Nitesh Narayan Lal
2021-06-17 18:22 ` [Intel-wired-lan] [PATCH v1 11/14] scsi: lpfc: Use irq_set_affinity Nitesh Narayan Lal
2021-06-17 18:22 ` [Intel-wired-lan] [PATCH v1 12/14] hinic: Use irq_set_affinity_and_hint Nitesh Narayan Lal
2021-06-17 18:22 ` [Intel-wired-lan] [PATCH v1 13/14] net/mlx5: Use irq_update_affinity_hint Nitesh Narayan Lal
2021-06-21  8:01   ` Leon Romanovsky
2021-06-17 18:22 ` [Intel-wired-lan] [PATCH v1 14/14] net/mlx4: " Nitesh Narayan Lal
2021-06-21  8:01   ` Leon Romanovsky
2021-06-21 12:59     ` Nitesh Lal
2021-06-25 21:08     ` Nitesh Lal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210617182242.8637-10-nitesh@redhat.com \
    --to=nitesh@redhat.com \
    --cc=intel-wired-lan@osuosl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox