Intel-Wired-Lan Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Nitesh Narayan Lal <nitesh@redhat.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [PATCH v3 12/14] hinic: Use irq_set_affinity_and_hint
Date: Tue, 13 Jul 2021 17:15:00 -0400	[thread overview]
Message-ID: <20210713211502.464259-13-nitesh@redhat.com> (raw)
In-Reply-To: <20210713211502.464259-1-nitesh@redhat.com>

The driver uses irq_set_affinity_hint() to:

- Set the affinity_hint which is consumed by the userspace for
  distributing the interrupts

- Enforce affinity

As per commit 352f58b0d9f2 ("net-next/hinic: Set Rxq irq to specific cpu
for NUMA"), the hinic driver enforces its own affinity to bind IRQs to the
local NUMA node. However, irq_set_affinity_hint() applying the provided
cpumask as an affinity for the interrupt is an undocumented side effect.

To remove this side effect irq_set_affinity_hint() has been marked as
deprecated and new interfaces have been introduced. Hence, replace the
irq_set_affinity_hint() with the new interface irq_set_affinity_and_hint()
where the provided mask needs to be applied as the affinity and
affinity_hint pointer needs to be set and replace with
irq_update_affinity_hint() where only affinity_hint needs to be updated.

Signed-off-by: Nitesh Narayan Lal <nitesh@redhat.com>
---
 drivers/net/ethernet/huawei/hinic/hinic_rx.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/huawei/hinic/hinic_rx.c b/drivers/net/ethernet/huawei/hinic/hinic_rx.c
index fed3b6bc0d76..b33ed4d92b71 100644
--- a/drivers/net/ethernet/huawei/hinic/hinic_rx.c
+++ b/drivers/net/ethernet/huawei/hinic/hinic_rx.c
@@ -548,7 +548,7 @@ static int rx_request_irq(struct hinic_rxq *rxq)
 		goto err_req_irq;
 
 	cpumask_set_cpu(qp->q_id % num_online_cpus(), &rq->affinity_mask);
-	err = irq_set_affinity_hint(rq->irq, &rq->affinity_mask);
+	err = irq_set_affinity_and_hint(rq->irq, &rq->affinity_mask);
 	if (err)
 		goto err_irq_affinity;
 
@@ -565,7 +565,7 @@ static void rx_free_irq(struct hinic_rxq *rxq)
 {
 	struct hinic_rq *rq = rxq->rq;
 
-	irq_set_affinity_hint(rq->irq, NULL);
+	irq_update_affinity_hint(rq->irq, NULL);
 	free_irq(rq->irq, rxq);
 	rx_del_napi(rxq);
 }
-- 
2.27.0


  parent reply	other threads:[~2021-07-13 21:15 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-13 21:14 [Intel-wired-lan] [PATCH v3 00/14] genirq: Cleanup the usage of irq_set_affinity_hint Nitesh Narayan Lal
2021-07-13 21:14 ` [Intel-wired-lan] [PATCH v3 01/14] genirq: Provide new interfaces for affinity hints Nitesh Narayan Lal
2021-07-13 21:14 ` [Intel-wired-lan] [PATCH v3 02/14] iavf: Use irq_update_affinity_hint Nitesh Narayan Lal
2021-07-13 21:51   ` Jesse Brandeburg
2021-07-13 21:14 ` [Intel-wired-lan] [PATCH v3 03/14] i40e: " Nitesh Narayan Lal
2021-07-13 21:52   ` Jesse Brandeburg
2021-07-13 21:14 ` [Intel-wired-lan] [PATCH v3 04/14] scsi: megaraid_sas: Use irq_set_affinity_and_hint Nitesh Narayan Lal
2021-07-13 21:14 ` [Intel-wired-lan] [PATCH v3 05/14] scsi: mpt3sas: " Nitesh Narayan Lal
2021-07-13 21:14 ` [Intel-wired-lan] [PATCH v3 06/14] RDMA/irdma: " Nitesh Narayan Lal
2021-07-14 12:03   ` Leon Romanovsky
2021-07-14 12:56     ` Nitesh Lal
2021-07-14 13:02       ` Leon Romanovsky
2021-07-15 13:25         ` Nitesh Lal
2021-07-13 21:14 ` [Intel-wired-lan] [PATCH v3 07/14] enic: Use irq_update_affinity_hint Nitesh Narayan Lal
2021-07-13 21:14 ` [Intel-wired-lan] [PATCH v3 08/14] be2net: " Nitesh Narayan Lal
2021-07-13 21:14 ` [Intel-wired-lan] [PATCH v3 09/14] ixgbe: " Nitesh Narayan Lal
2021-07-13 22:01   ` Jesse Brandeburg
2021-07-13 21:14 ` [Intel-wired-lan] [PATCH v3 10/14] mailbox: " Nitesh Narayan Lal
2021-07-13 21:14 ` [Intel-wired-lan] [PATCH v3 11/14] scsi: lpfc: Use irq_set_affinity Nitesh Narayan Lal
2021-07-13 21:15 ` Nitesh Narayan Lal [this message]
2021-07-13 21:15 ` [Intel-wired-lan] [PATCH v3 13/14] net/mlx5: Use irq_set_affinity_and_hint Nitesh Narayan Lal
2021-07-14 12:01   ` Leon Romanovsky
2021-07-13 21:15 ` [Intel-wired-lan] [PATCH v3 14/14] net/mlx4: Use irq_update_affinity_hint Nitesh Narayan Lal
2021-07-14 11:19   ` Tariq Toukan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210713211502.464259-13-nitesh@redhat.com \
    --to=nitesh@redhat.com \
    --cc=intel-wired-lan@osuosl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox