Intel-Wired-Lan Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Intel-wired-lan] [PATCH net v3] i40e: Fix pre-set max number of queues for VF
@ 2021-07-16  9:33 Mateusz Palczewski
  2021-11-30  9:37 ` P, Bindushree
  0 siblings, 1 reply; 2+ messages in thread
From: Mateusz Palczewski @ 2021-07-16  9:33 UTC (permalink / raw)
  To: intel-wired-lan

After setting pre-set combined to 16 queues and reserving 16 queues by
tc qdisc, pre-set maximum combined queues returned to default value
after VF reset being 4 and this generated errors during removing tc.
Fixed by removing clear num_req_queues before reset VF.

Fixes: e284fc280473 (i40e: Add and delete cloud filter)
Change-Id: Ib2db315e4b04eeb15e12301edf833014a929e914
Signed-off-by: Grzegorz Szczurek <grzegorzx.szczurek@intel.com>
Signed-off-by: Mateusz Palczewski <mateusz.palczewski@intel.com>
---
 v2: Refactored commit message
 v3: Fixed wrong e-mail address in commit message
---
 drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c b/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c
index 4da982b..c007fba 100644
--- a/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c
+++ b/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c
@@ -3873,11 +3873,6 @@ static int i40e_vc_add_qch_msg(struct i40e_vf *vf, u8 *msg)
 
 	/* set this flag only after making sure all inputs are sane */
 	vf->adq_enabled = true;
-	/* num_req_queues is set when user changes number of queues via ethtool
-	 * and this causes issue for default VSI(which depends on this variable)
-	 * when ADq is enabled, hence reset it.
-	 */
-	vf->num_req_queues = 0;
 
 	/* reset the VF in order to allocate resources */
 	i40e_vc_reset_vf(vf, true);
-- 
2.27.0


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [Intel-wired-lan] [PATCH net v3] i40e: Fix pre-set max number of queues for VF
  2021-07-16  9:33 [Intel-wired-lan] [PATCH net v3] i40e: Fix pre-set max number of queues for VF Mateusz Palczewski
@ 2021-11-30  9:37 ` P, Bindushree
  0 siblings, 0 replies; 2+ messages in thread
From: P, Bindushree @ 2021-11-30  9:37 UTC (permalink / raw)
  To: intel-wired-lan



> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of
> Palczewski, Mateusz
> Sent: Friday, July 16, 2021 3:04 PM
> To: intel-wired-lan at lists.osuosl.org
> Cc: Palczewski, Mateusz <mateusz.palczewski@intel.com>
> Subject: [Intel-wired-lan] [PATCH net v3] i40e: Fix pre-set max number of
> queues for VF
> 
> After setting pre-set combined to 16 queues and reserving 16 queues by tc
> qdisc, pre-set maximum combined queues returned to default value after VF
> reset being 4 and this generated errors during removing tc.
> Fixed by removing clear num_req_queues before reset VF.
> 
> Fixes: e284fc280473 (i40e: Add and delete cloud filter)
> Change-Id: Ib2db315e4b04eeb15e12301edf833014a929e914
> Signed-off-by: Grzegorz Szczurek <grzegorzx.szczurek@intel.com>
> Signed-off-by: Mateusz Palczewski <mateusz.palczewski@intel.com>
> ---
>  v2: Refactored commit message
>  v3: Fixed wrong e-mail address in commit message
> ---
>  drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c | 5 -----
>  1 file changed, 5 deletions(-)
> 
Tested-by: P, Bindushree  <Bindushree.p@intel.com>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-11-30  9:37 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-07-16  9:33 [Intel-wired-lan] [PATCH net v3] i40e: Fix pre-set max number of queues for VF Mateusz Palczewski
2021-11-30  9:37 ` P, Bindushree

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox