Intel-Wired-Lan Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Cochran <richardcochran@gmail.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [RFC v2 net-next 1/2] rtnetlink: Add new RTM_GETSYNCESTATE message to get SyncE status
Date: Sun, 29 Aug 2021 08:10:17 -0700	[thread overview]
Message-ID: <20210829151017.GA6016@hoboy.vegasvil.org> (raw)
In-Reply-To: <20210829080512.3573627-2-maciej.machnikowski@intel.com>

On Sun, Aug 29, 2021 at 10:05:11AM +0200, Maciej Machnikowski wrote:
> This patch adds the new RTM_GETSYNCESTATE message to query the status
> of SyncE syntonization on the device.
> 
> Initial implementation returns:
>  - SyncE DPLL state
>  - Source of signal driving SyncE DPLL (SyncE, GNSS, PTP or External)
>  - Current index of Pin driving the DPLL
> 
> SyncE state read needs to be implemented as ndo_get_synce_state function.
> 
> This patch is SyncE-oriented. Future implementation can add additional
> functionality for reading different DPLL states using the same structure.

I would call this more "ice oriented" than SyncE oriented.  I'm not
sure there is even such a thing as "SyncE DPLL".  Does that term come
from 802.3?  To my understanding, that is one just way of implementing
it that works on super-Gigabit speed devices.

I have nothing against exposing the DPLL if you need to, however I'd
like to have an interface that support plain Gigabit as well.  This
could be done in a generic way by offering Control Register 9 as
described in 802.3.

Thanks,
Richard

  reply	other threads:[~2021-08-29 15:10 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-29  8:05 [Intel-wired-lan] [RFC v2 net-next 0/2] Add RTNL interface for SyncE Maciej Machnikowski
2021-08-29  8:05 ` [Intel-wired-lan] [RFC v2 net-next 1/2] rtnetlink: Add new RTM_GETSYNCESTATE message to get SyncE status Maciej Machnikowski
2021-08-29 15:10   ` Richard Cochran [this message]
2021-08-29 16:42     ` Machnikowski, Maciej
2021-08-29 20:16       ` Andrew Lunn
2021-08-30 20:57       ` Richard Cochran
2021-08-30 23:29         ` Jakub Kicinski
2021-08-31 10:20           ` Machnikowski, Maciej
2021-08-31 13:33             ` Jakub Kicinski
2021-08-31 14:07               ` Machnikowski, Maciej
2021-08-31 14:18                 ` Jakub Kicinski
2021-08-31 15:19                   ` Machnikowski, Maciej
2021-08-31 15:32                     ` Jakub Kicinski
2021-08-31 16:00                       ` Machnikowski, Maciej
2021-08-31 16:19           ` Richard Cochran
2021-08-31 22:09             ` Machnikowski, Maciej
2021-09-01  2:02               ` Jakub Kicinski
2021-09-01  2:56                 ` Richard Cochran
2021-09-01  1:58             ` Jakub Kicinski
2021-09-01  2:55               ` Richard Cochran
2021-08-29  8:05 ` [Intel-wired-lan] [RFC v2 net-next 2/2] ice: add support for reading SyncE DPLL state Maciej Machnikowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210829151017.GA6016@hoboy.vegasvil.org \
    --to=richardcochran@gmail.com \
    --cc=intel-wired-lan@osuosl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox