From: Richard Cochran <richardcochran@gmail.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [RFC v2 net-next 1/2] rtnetlink: Add new RTM_GETSYNCESTATE message to get SyncE status
Date: Mon, 30 Aug 2021 13:57:58 -0700 [thread overview]
Message-ID: <20210830205758.GA26230@hoboy.vegasvil.org> (raw)
In-Reply-To: <PH0PR11MB495126A63998DABA5B5DE184EACA9@PH0PR11MB4951.namprd11.prod.outlook.com>
On Sun, Aug 29, 2021 at 04:42:55PM +0000, Machnikowski, Maciej wrote:
> Please take a look at the 10.2 Operation modes of the G.8264 and at the Figure A.1
> which depicts the EEC. This interface is to report the status of the EEC.
Well, I read it, and it is still fairly high level with no mention at
all of "DPLL". I hope that the new RTNL states will cover other
possible EEC implementations, too.
The "Reference source selection mechanism" is also quite vague. Your
patch is more specific:
+enum if_eec_src {
+ IF_EEC_SRC_INVALID = 0,
+ IF_EEC_SRC_UNKNOWN,
+ IF_EEC_SRC_SYNCE,
+ IF_EEC_SRC_GNSS,
+ IF_EEC_SRC_PTP,
+ IF_EEC_SRC_EXT,
+ __IF_EEC_SRC_MAX,
+};
But I guess your list is reasonable. It can always be expanded, right?
> If you prefer EEC over DPLL I'm fine with the name change. I think it will be less confusing.
Yes, thanks for doing that.
Thanks,
Richard
next prev parent reply other threads:[~2021-08-30 20:57 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-29 8:05 [Intel-wired-lan] [RFC v2 net-next 0/2] Add RTNL interface for SyncE Maciej Machnikowski
2021-08-29 8:05 ` [Intel-wired-lan] [RFC v2 net-next 1/2] rtnetlink: Add new RTM_GETSYNCESTATE message to get SyncE status Maciej Machnikowski
2021-08-29 15:10 ` Richard Cochran
2021-08-29 16:42 ` Machnikowski, Maciej
2021-08-29 20:16 ` Andrew Lunn
2021-08-30 20:57 ` Richard Cochran [this message]
2021-08-30 23:29 ` Jakub Kicinski
2021-08-31 10:20 ` Machnikowski, Maciej
2021-08-31 13:33 ` Jakub Kicinski
2021-08-31 14:07 ` Machnikowski, Maciej
2021-08-31 14:18 ` Jakub Kicinski
2021-08-31 15:19 ` Machnikowski, Maciej
2021-08-31 15:32 ` Jakub Kicinski
2021-08-31 16:00 ` Machnikowski, Maciej
2021-08-31 16:19 ` Richard Cochran
2021-08-31 22:09 ` Machnikowski, Maciej
2021-09-01 2:02 ` Jakub Kicinski
2021-09-01 2:56 ` Richard Cochran
2021-09-01 1:58 ` Jakub Kicinski
2021-09-01 2:55 ` Richard Cochran
2021-08-29 8:05 ` [Intel-wired-lan] [RFC v2 net-next 2/2] ice: add support for reading SyncE DPLL state Maciej Machnikowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210830205758.GA26230@hoboy.vegasvil.org \
--to=richardcochran@gmail.com \
--cc=intel-wired-lan@osuosl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox