* [Intel-wired-lan] [PATCH 5.14 058/162] igc: fix build errors for PTP [not found] <20210927170233.453060397@linuxfoundation.org> @ 2021-09-27 17:01 ` Greg Kroah-Hartman 2021-10-04 4:15 ` Andre Tomt 0 siblings, 1 reply; 3+ messages in thread From: Greg Kroah-Hartman @ 2021-09-27 17:01 UTC (permalink / raw) To: intel-wired-lan From: Randy Dunlap <rdunlap@infradead.org> [ Upstream commit 87758511075ec961486fe78d7548dd709b524433 ] When IGC=y and PTP_1588_CLOCK=m, the ptp_*() interface family is not available to the igc driver. Make this driver depend on PTP_1588_CLOCK_OPTIONAL so that it will build without errors. Various igc commits have used ptp_*() functions without checking that PTP_1588_CLOCK is enabled. Fix all of these here. Fixes these build errors: ld: drivers/net/ethernet/intel/igc/igc_main.o: in function `igc_msix_other': igc_main.c:(.text+0x6494): undefined reference to `ptp_clock_event' ld: igc_main.c:(.text+0x64ef): undefined reference to `ptp_clock_event' ld: igc_main.c:(.text+0x6559): undefined reference to `ptp_clock_event' ld: drivers/net/ethernet/intel/igc/igc_ethtool.o: in function `igc_ethtool_get_ts_info': igc_ethtool.c:(.text+0xc7a): undefined reference to `ptp_clock_index' ld: drivers/net/ethernet/intel/igc/igc_ptp.o: in function `igc_ptp_feature_enable_i225': igc_ptp.c:(.text+0x330): undefined reference to `ptp_find_pin' ld: igc_ptp.c:(.text+0x36f): undefined reference to `ptp_find_pin' ld: drivers/net/ethernet/intel/igc/igc_ptp.o: in function `igc_ptp_init': igc_ptp.c:(.text+0x11cd): undefined reference to `ptp_clock_register' ld: drivers/net/ethernet/intel/igc/igc_ptp.o: in function `igc_ptp_stop': igc_ptp.c:(.text+0x12dd): undefined reference to `ptp_clock_unregister' ld: drivers/platform/x86/dell/dell-wmi-privacy.o: in function `dell_privacy_wmi_probe': Fixes: 64433e5bf40ab ("igc: Enable internal i225 PPS") Fixes: 60dbede0c4f3d ("igc: Add support for ethtool GET_TS_INFO command") Fixes: 87938851b6efb ("igc: enable auxiliary PHC functions for the i225") Fixes: 5f2958052c582 ("igc: Add basic skeleton for PTP") Signed-off-by: Randy Dunlap <rdunlap@infradead.org> Cc: Ederson de Souza <ederson.desouza@intel.com> Cc: Tony Nguyen <anthony.l.nguyen@intel.com> Cc: Vinicius Costa Gomes <vinicius.gomes@intel.com> Cc: Jeff Kirsher <jeffrey.t.kirsher@intel.com> Cc: "David S. Miller" <davem@davemloft.net> Cc: Jakub Kicinski <kuba@kernel.org> Cc: Jesse Brandeburg <jesse.brandeburg@intel.com> Cc: intel-wired-lan at lists.osuosl.org Acked-by: Vinicius Costa Gomes <vinicius.gomes@intel.com> Signed-off-by: David S. Miller <davem@davemloft.net> Signed-off-by: Sasha Levin <sashal@kernel.org> --- drivers/net/ethernet/intel/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/intel/Kconfig b/drivers/net/ethernet/intel/Kconfig index 82744a7501c7..c11d974a62d8 100644 --- a/drivers/net/ethernet/intel/Kconfig +++ b/drivers/net/ethernet/intel/Kconfig @@ -335,6 +335,7 @@ config IGC tristate "Intel(R) Ethernet Controller I225-LM/I225-V support" default n depends on PCI + depends on PTP_1588_CLOCK_OPTIONAL help This driver supports Intel(R) Ethernet Controller I225-LM/I225-V family of adapters. -- 2.33.0 ^ permalink raw reply related [flat|nested] 3+ messages in thread
* [Intel-wired-lan] [PATCH 5.14 058/162] igc: fix build errors for PTP 2021-09-27 17:01 ` [Intel-wired-lan] [PATCH 5.14 058/162] igc: fix build errors for PTP Greg Kroah-Hartman @ 2021-10-04 4:15 ` Andre Tomt 2021-10-04 10:48 ` Greg Kroah-Hartman 0 siblings, 1 reply; 3+ messages in thread From: Andre Tomt @ 2021-10-04 4:15 UTC (permalink / raw) To: intel-wired-lan On 27.09.2021 19:01, Greg Kroah-Hartman wrote: > From: Randy Dunlap <rdunlap@infradead.org> > > [ Upstream commit 87758511075ec961486fe78d7548dd709b524433 ] > > When IGC=y and PTP_1588_CLOCK=m, the ptp_*() interface family is > not available to the igc driver. Make this driver depend on > PTP_1588_CLOCK_OPTIONAL so that it will build without errors. > > Various igc commits have used ptp_*() functions without checking > that PTP_1588_CLOCK is enabled. Fix all of these here. > > Fixes these build errors: > > ld: drivers/net/ethernet/intel/igc/igc_main.o: in function `igc_msix_other': > igc_main.c:(.text+0x6494): undefined reference to `ptp_clock_event' > ld: igc_main.c:(.text+0x64ef): undefined reference to `ptp_clock_event' > ld: igc_main.c:(.text+0x6559): undefined reference to `ptp_clock_event' > ld: drivers/net/ethernet/intel/igc/igc_ethtool.o: in function `igc_ethtool_get_ts_info': > igc_ethtool.c:(.text+0xc7a): undefined reference to `ptp_clock_index' > ld: drivers/net/ethernet/intel/igc/igc_ptp.o: in function `igc_ptp_feature_enable_i225': > igc_ptp.c:(.text+0x330): undefined reference to `ptp_find_pin' > ld: igc_ptp.c:(.text+0x36f): undefined reference to `ptp_find_pin' > ld: drivers/net/ethernet/intel/igc/igc_ptp.o: in function `igc_ptp_init': > igc_ptp.c:(.text+0x11cd): undefined reference to `ptp_clock_register' > ld: drivers/net/ethernet/intel/igc/igc_ptp.o: in function `igc_ptp_stop': > igc_ptp.c:(.text+0x12dd): undefined reference to `ptp_clock_unregister' > ld: drivers/platform/x86/dell/dell-wmi-privacy.o: in function `dell_privacy_wmi_probe': > > Fixes: 64433e5bf40ab ("igc: Enable internal i225 PPS") > Fixes: 60dbede0c4f3d ("igc: Add support for ethtool GET_TS_INFO command") > Fixes: 87938851b6efb ("igc: enable auxiliary PHC functions for the i225") > Fixes: 5f2958052c582 ("igc: Add basic skeleton for PTP") > Signed-off-by: Randy Dunlap <rdunlap@infradead.org> > Cc: Ederson de Souza <ederson.desouza@intel.com> > Cc: Tony Nguyen <anthony.l.nguyen@intel.com> > Cc: Vinicius Costa Gomes <vinicius.gomes@intel.com> > Cc: Jeff Kirsher <jeffrey.t.kirsher@intel.com> > Cc: "David S. Miller" <davem@davemloft.net> > Cc: Jakub Kicinski <kuba@kernel.org> > Cc: Jesse Brandeburg <jesse.brandeburg@intel.com> > Cc: intel-wired-lan at lists.osuosl.org > Acked-by: Vinicius Costa Gomes <vinicius.gomes@intel.com> > Signed-off-by: David S. Miller <davem@davemloft.net> > Signed-off-by: Sasha Levin <sashal@kernel.org> > --- > drivers/net/ethernet/intel/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/ethernet/intel/Kconfig b/drivers/net/ethernet/intel/Kconfig > index 82744a7501c7..c11d974a62d8 100644 > --- a/drivers/net/ethernet/intel/Kconfig > +++ b/drivers/net/ethernet/intel/Kconfig > @@ -335,6 +335,7 @@ config IGC > tristate "Intel(R) Ethernet Controller I225-LM/I225-V support" > default n > depends on PCI > + depends on PTP_1588_CLOCK_OPTIONAL > help > This driver supports Intel(R) Ethernet Controller I225-LM/I225-V > family of adapters. > PTP_1588_CLOCK_OPTIONAL does not exist in 5.14, so this effectively disables the igc driver completely when applied to stable as-is. ^ permalink raw reply [flat|nested] 3+ messages in thread
* [Intel-wired-lan] [PATCH 5.14 058/162] igc: fix build errors for PTP 2021-10-04 4:15 ` Andre Tomt @ 2021-10-04 10:48 ` Greg Kroah-Hartman 0 siblings, 0 replies; 3+ messages in thread From: Greg Kroah-Hartman @ 2021-10-04 10:48 UTC (permalink / raw) To: intel-wired-lan On Mon, Oct 04, 2021 at 06:15:56AM +0200, Andre Tomt wrote: > On 27.09.2021 19:01, Greg Kroah-Hartman wrote: > > From: Randy Dunlap <rdunlap@infradead.org> > > > > [ Upstream commit 87758511075ec961486fe78d7548dd709b524433 ] > > > > When IGC=y and PTP_1588_CLOCK=m, the ptp_*() interface family is > > not available to the igc driver. Make this driver depend on > > PTP_1588_CLOCK_OPTIONAL so that it will build without errors. > > > > Various igc commits have used ptp_*() functions without checking > > that PTP_1588_CLOCK is enabled. Fix all of these here. > > > > Fixes these build errors: > > > > ld: drivers/net/ethernet/intel/igc/igc_main.o: in function `igc_msix_other': > > igc_main.c:(.text+0x6494): undefined reference to `ptp_clock_event' > > ld: igc_main.c:(.text+0x64ef): undefined reference to `ptp_clock_event' > > ld: igc_main.c:(.text+0x6559): undefined reference to `ptp_clock_event' > > ld: drivers/net/ethernet/intel/igc/igc_ethtool.o: in function `igc_ethtool_get_ts_info': > > igc_ethtool.c:(.text+0xc7a): undefined reference to `ptp_clock_index' > > ld: drivers/net/ethernet/intel/igc/igc_ptp.o: in function `igc_ptp_feature_enable_i225': > > igc_ptp.c:(.text+0x330): undefined reference to `ptp_find_pin' > > ld: igc_ptp.c:(.text+0x36f): undefined reference to `ptp_find_pin' > > ld: drivers/net/ethernet/intel/igc/igc_ptp.o: in function `igc_ptp_init': > > igc_ptp.c:(.text+0x11cd): undefined reference to `ptp_clock_register' > > ld: drivers/net/ethernet/intel/igc/igc_ptp.o: in function `igc_ptp_stop': > > igc_ptp.c:(.text+0x12dd): undefined reference to `ptp_clock_unregister' > > ld: drivers/platform/x86/dell/dell-wmi-privacy.o: in function `dell_privacy_wmi_probe': > > > > Fixes: 64433e5bf40ab ("igc: Enable internal i225 PPS") > > Fixes: 60dbede0c4f3d ("igc: Add support for ethtool GET_TS_INFO command") > > Fixes: 87938851b6efb ("igc: enable auxiliary PHC functions for the i225") > > Fixes: 5f2958052c582 ("igc: Add basic skeleton for PTP") > > Signed-off-by: Randy Dunlap <rdunlap@infradead.org> > > Cc: Ederson de Souza <ederson.desouza@intel.com> > > Cc: Tony Nguyen <anthony.l.nguyen@intel.com> > > Cc: Vinicius Costa Gomes <vinicius.gomes@intel.com> > > Cc: Jeff Kirsher <jeffrey.t.kirsher@intel.com> > > Cc: "David S. Miller" <davem@davemloft.net> > > Cc: Jakub Kicinski <kuba@kernel.org> > > Cc: Jesse Brandeburg <jesse.brandeburg@intel.com> > > Cc: intel-wired-lan at lists.osuosl.org > > Acked-by: Vinicius Costa Gomes <vinicius.gomes@intel.com> > > Signed-off-by: David S. Miller <davem@davemloft.net> > > Signed-off-by: Sasha Levin <sashal@kernel.org> > > --- > > drivers/net/ethernet/intel/Kconfig | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/net/ethernet/intel/Kconfig b/drivers/net/ethernet/intel/Kconfig > > index 82744a7501c7..c11d974a62d8 100644 > > --- a/drivers/net/ethernet/intel/Kconfig > > +++ b/drivers/net/ethernet/intel/Kconfig > > @@ -335,6 +335,7 @@ config IGC > > tristate "Intel(R) Ethernet Controller I225-LM/I225-V support" > > default n > > depends on PCI > > + depends on PTP_1588_CLOCK_OPTIONAL > > help > > This driver supports Intel(R) Ethernet Controller I225-LM/I225-V > > family of adapters. > > > > PTP_1588_CLOCK_OPTIONAL does not exist in 5.14, so this effectively disables > the igc driver completely when applied to stable as-is. Now dropped from the queue, again :) thanks, greg k-h ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-10-04 10:48 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20210927170233.453060397@linuxfoundation.org>
2021-09-27 17:01 ` [Intel-wired-lan] [PATCH 5.14 058/162] igc: fix build errors for PTP Greg Kroah-Hartman
2021-10-04 4:15 ` Andre Tomt
2021-10-04 10:48 ` Greg Kroah-Hartman
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox