* [Intel-wired-lan] [PATCH net-next] ice: remove unnecessary RTNL lock assert
@ 2021-10-27 4:32 Michal Swiatkowski
0 siblings, 0 replies; only message in thread
From: Michal Swiatkowski @ 2021-10-27 4:32 UTC (permalink / raw)
To: intel-wired-lan
Follow changes in commit 7c3a0a018e67 ("net/{mlx5|nfp|bnxt}: Remove
unnecessary RTNL lock assert").
Remove the assert from the callback priv lookup function since it does
not require RTNL lock and is already protected by flow_indr_block_lock.
Having this assert in the ice_indr_block_priv_lookup leads to ugly
assert failed information in dmesg after:
- creating gretap tunnel
- adding tc qdisc on the tunnel device
- rmmod driver
- insmod driver
As this assert isn't needed, remove it.
Signed-off-by: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
---
This commit should be squashed with "ice: support for indirect notification"
drivers/net/ethernet/intel/ice/ice_main.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/net/ethernet/intel/ice/ice_main.c b/drivers/net/ethernet/intel/ice/ice_main.c
index 728c11103b37..d7ecbec93b11 100644
--- a/drivers/net/ethernet/intel/ice/ice_main.c
+++ b/drivers/net/ethernet/intel/ice/ice_main.c
@@ -8153,9 +8153,6 @@ ice_indr_block_priv_lookup(struct ice_netdev_priv *np,
{
struct ice_indr_block_priv *cb_priv;
- /* All callback list access should be protected by RTNL. */
- ASSERT_RTNL();
-
list_for_each_entry(cb_priv, &np->tc_indr_block_priv_list, list) {
if (!cb_priv->netdev)
return NULL;
--
2.31.1
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2021-10-27 4:32 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-10-27 4:32 [Intel-wired-lan] [PATCH net-next] ice: remove unnecessary RTNL lock assert Michal Swiatkowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox