Intel-Wired-Lan Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Intel-wired-lan] [PATCH net v1] i40e: Fix display error code in dmesg
@ 2021-10-29  9:26 Mateusz Palczewski
  2021-11-03 22:10 ` Switzer, David
  0 siblings, 1 reply; 2+ messages in thread
From: Mateusz Palczewski @ 2021-10-29  9:26 UTC (permalink / raw)
  To: intel-wired-lan

From: Grzegorz Szczurek <grzegorzx.szczurek@intel.com>

Fix misleading display error in dmesg if tc filter return fail.
Only i40e status error code should be converted to string, not linux
error code. Otherwise, we return false information about the error.

Fixes: 2f4b411a3d67 ("i40e: Enable cloud filters via tc-flower")
Signed-off-by: Grzegorz Szczurek <grzegorzx.szczurek@intel.com>
Signed-off-by: Mateusz Palczewski <mateusz.palczewski@intel.com>
---
 drivers/net/ethernet/intel/i40e/i40e_main.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c
index 4664d07..8f1f870 100644
--- a/drivers/net/ethernet/intel/i40e/i40e_main.c
+++ b/drivers/net/ethernet/intel/i40e/i40e_main.c
@@ -8557,8 +8557,7 @@ static int i40e_configure_clsflower(struct i40e_vsi *vsi,
 
 	if (err) {
 		dev_err(&pf->pdev->dev,
-			"Failed to add cloud filter, err %s\n",
-			i40e_stat_str(&pf->hw, err));
+			"Failed to add cloud filter, err %d\n", err);
 		goto err;
 	}
 
-- 
2.27.0


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [Intel-wired-lan] [PATCH net v1] i40e: Fix display error code in dmesg
  2021-10-29  9:26 [Intel-wired-lan] [PATCH net v1] i40e: Fix display error code in dmesg Mateusz Palczewski
@ 2021-11-03 22:10 ` Switzer, David
  0 siblings, 0 replies; 2+ messages in thread
From: Switzer, David @ 2021-11-03 22:10 UTC (permalink / raw)
  To: intel-wired-lan

>-----Original Message-----
>From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of
>Mateusz Palczewski
>Sent: Friday, October 29, 2021 2:26 AM
To: intel-wired-lan@lists.osuosl.org
>Cc: Palczewski, Mateusz <mateusz.palczewski@intel.com>
>Subject: [Intel-wired-lan] [PATCH net v1] i40e: Fix display error code in dmesg
>
>From: Grzegorz Szczurek <grzegorzx.szczurek@intel.com>
>
>Fix misleading display error in dmesg if tc filter return fail.
>Only i40e status error code should be converted to string, not linux error code.
>Otherwise, we return false information about the error.
>
>Fixes: 2f4b411a3d67 ("i40e: Enable cloud filters via tc-flower")
>Signed-off-by: Grzegorz Szczurek <grzegorzx.szczurek@intel.com>
>Signed-off-by: Mateusz Palczewski <mateusz.palczewski@intel.com>
>---
> drivers/net/ethernet/intel/i40e/i40e_main.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
Tested-by: Dave Switzer <david.switzer@intel.com>


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-11-03 22:10 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-10-29  9:26 [Intel-wired-lan] [PATCH net v1] i40e: Fix display error code in dmesg Mateusz Palczewski
2021-11-03 22:10 ` Switzer, David

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox