From: kernel test robot <lkp@intel.com>
To: Vinicius Costa Gomes <vinicius.gomes@intel.com>, jhogan@kernel.org
Cc: Paul Menzel <pmenzel@molgen.mpg.de>,
kbuild-all@lists.01.org, netdev@vger.kernel.org,
llvm@lists.linux.dev,
Jesse Brandeburg <jesse.brandeburg@intel.com>,
Aleksandr Loktionov <aleksandr.loktionov@intel.com>,
intel-wired-lan@lists.osuosl.org
Subject: Re: [Intel-wired-lan] [PATCH] igc: fix deadlock caused by taking RTNL in RPM resume path
Date: Fri, 12 Aug 2022 02:58:15 +0800 [thread overview]
Message-ID: <202208120244.a7CKRiFy-lkp@intel.com> (raw)
In-Reply-To: <20220811151342.19059-1-vinicius.gomes@intel.com>
Hi Vinicius,
I love your patch! Yet something to improve:
[auto build test ERROR on tnguy-next-queue/dev-queue]
[also build test ERROR on linus/master v5.19 next-20220811]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Vinicius-Costa-Gomes/igc-fix-deadlock-caused-by-taking-RTNL-in-RPM-resume-path/20220811-232032
base: https://git.kernel.org/pub/scm/linux/kernel/git/tnguy/next-queue.git dev-queue
config: i386-randconfig-a013 (https://download.01.org/0day-ci/archive/20220812/202208120244.a7CKRiFy-lkp@intel.com/config)
compiler: clang version 16.0.0 (https://github.com/llvm/llvm-project 5f1c7e2cc5a3c07cbc2412e851a7283c1841f520)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/61ed7ed758f23a10549c5d4fdc82ef9356281cbf
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Vinicius-Costa-Gomes/igc-fix-deadlock-caused-by-taking-RTNL-in-RPM-resume-path/20220811-232032
git checkout 61ed7ed758f23a10549c5d4fdc82ef9356281cbf
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 SHELL=/bin/bash drivers/net/ethernet/intel/igc/
If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
>> drivers/net/ethernet/intel/igc/igc_main.c:6838:26: error: use of undeclared identifier 'igc_suspend'; did you mean '__igc_suspend'?
SET_SYSTEM_SLEEP_PM_OPS(igc_suspend, igc_resume)
^~~~~~~~~~~
__igc_suspend
include/linux/pm.h:343:22: note: expanded from macro 'SET_SYSTEM_SLEEP_PM_OPS'
SYSTEM_SLEEP_PM_OPS(suspend_fn, resume_fn)
^
include/linux/pm.h:313:26: note: expanded from macro 'SYSTEM_SLEEP_PM_OPS'
.suspend = pm_sleep_ptr(suspend_fn), \
^
include/linux/pm.h:439:65: note: expanded from macro 'pm_sleep_ptr'
#define pm_sleep_ptr(_ptr) PTR_IF(IS_ENABLED(CONFIG_PM_SLEEP), (_ptr))
^
include/linux/kernel.h:57:38: note: expanded from macro 'PTR_IF'
#define PTR_IF(cond, ptr) ((cond) ? (ptr) : NULL)
^
drivers/net/ethernet/intel/igc/igc_main.c:6706:27: note: '__igc_suspend' declared here
static int __maybe_unused __igc_suspend(struct device *dev)
^
>> drivers/net/ethernet/intel/igc/igc_main.c:6838:26: error: use of undeclared identifier 'igc_suspend'; did you mean '__igc_suspend'?
SET_SYSTEM_SLEEP_PM_OPS(igc_suspend, igc_resume)
^~~~~~~~~~~
__igc_suspend
include/linux/pm.h:343:22: note: expanded from macro 'SET_SYSTEM_SLEEP_PM_OPS'
SYSTEM_SLEEP_PM_OPS(suspend_fn, resume_fn)
^
include/linux/pm.h:315:25: note: expanded from macro 'SYSTEM_SLEEP_PM_OPS'
.freeze = pm_sleep_ptr(suspend_fn), \
^
include/linux/pm.h:439:65: note: expanded from macro 'pm_sleep_ptr'
#define pm_sleep_ptr(_ptr) PTR_IF(IS_ENABLED(CONFIG_PM_SLEEP), (_ptr))
^
include/linux/kernel.h:57:38: note: expanded from macro 'PTR_IF'
#define PTR_IF(cond, ptr) ((cond) ? (ptr) : NULL)
^
drivers/net/ethernet/intel/igc/igc_main.c:6706:27: note: '__igc_suspend' declared here
static int __maybe_unused __igc_suspend(struct device *dev)
^
>> drivers/net/ethernet/intel/igc/igc_main.c:6838:26: error: use of undeclared identifier 'igc_suspend'; did you mean '__igc_suspend'?
SET_SYSTEM_SLEEP_PM_OPS(igc_suspend, igc_resume)
^~~~~~~~~~~
__igc_suspend
include/linux/pm.h:343:22: note: expanded from macro 'SET_SYSTEM_SLEEP_PM_OPS'
SYSTEM_SLEEP_PM_OPS(suspend_fn, resume_fn)
^
include/linux/pm.h:317:27: note: expanded from macro 'SYSTEM_SLEEP_PM_OPS'
.poweroff = pm_sleep_ptr(suspend_fn), \
^
include/linux/pm.h:439:65: note: expanded from macro 'pm_sleep_ptr'
#define pm_sleep_ptr(_ptr) PTR_IF(IS_ENABLED(CONFIG_PM_SLEEP), (_ptr))
^
include/linux/kernel.h:57:38: note: expanded from macro 'PTR_IF'
#define PTR_IF(cond, ptr) ((cond) ? (ptr) : NULL)
^
drivers/net/ethernet/intel/igc/igc_main.c:6706:27: note: '__igc_suspend' declared here
static int __maybe_unused __igc_suspend(struct device *dev)
^
3 errors generated.
vim +6838 drivers/net/ethernet/intel/igc/igc_main.c
bc23aa949aeba0 Sasha Neftin 2020-01-29 6835
9513d2a5dc7f3f Sasha Neftin 2019-11-14 6836 #ifdef CONFIG_PM
9513d2a5dc7f3f Sasha Neftin 2019-11-14 6837 static const struct dev_pm_ops igc_pm_ops = {
9513d2a5dc7f3f Sasha Neftin 2019-11-14 @6838 SET_SYSTEM_SLEEP_PM_OPS(igc_suspend, igc_resume)
9513d2a5dc7f3f Sasha Neftin 2019-11-14 6839 SET_RUNTIME_PM_OPS(igc_runtime_suspend, igc_runtime_resume,
9513d2a5dc7f3f Sasha Neftin 2019-11-14 6840 igc_runtime_idle)
9513d2a5dc7f3f Sasha Neftin 2019-11-14 6841 };
9513d2a5dc7f3f Sasha Neftin 2019-11-14 6842 #endif
9513d2a5dc7f3f Sasha Neftin 2019-11-14 6843
--
0-DAY CI Kernel Test Service
https://01.org/lkp
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
next prev parent reply other threads:[~2022-08-11 18:59 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-14 8:14 [Intel-wired-lan] I225-V (igc driver) hangs after resume in igc_resume/igc_tsn_reset James Hogan
2022-07-15 17:25 ` Tony Nguyen
2022-07-17 19:59 ` Vinicius Costa Gomes
[not found] ` <4773114.31r3eYUQgx@saruman>
2022-07-23 15:52 ` James Hogan
2022-07-27 14:37 ` Vinicius Costa Gomes
2022-07-28 17:36 ` James Hogan
2022-08-04 13:03 ` James Hogan
2022-08-04 13:27 ` Paul Menzel
2022-08-04 21:41 ` James Hogan
2022-08-04 22:07 ` James Hogan
2022-08-05 11:25 ` James Hogan
2022-08-11 15:13 ` [Intel-wired-lan] [PATCH] igc: fix deadlock caused by taking RTNL in RPM resume path Vinicius Costa Gomes
2022-08-11 18:58 ` kernel test robot [this message]
2022-08-11 19:59 ` kernel test robot
2022-08-11 20:25 ` [Intel-wired-lan] [WIP v2] " Vinicius Costa Gomes
2022-08-11 21:41 ` James Hogan
2022-08-13 0:05 ` Vinicius Costa Gomes
2022-08-13 17:18 ` James Hogan
2022-08-29 8:16 ` James Hogan
2022-10-02 10:56 ` James Hogan
2023-08-14 11:04 ` James Hogan
2023-08-29 1:58 ` Vinicius Costa Gomes
2023-09-03 17:57 ` James Hogan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202208120244.a7CKRiFy-lkp@intel.com \
--to=lkp@intel.com \
--cc=aleksandr.loktionov@intel.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jesse.brandeburg@intel.com \
--cc=jhogan@kernel.org \
--cc=kbuild-all@lists.01.org \
--cc=llvm@lists.linux.dev \
--cc=netdev@vger.kernel.org \
--cc=pmenzel@molgen.mpg.de \
--cc=vinicius.gomes@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox