[Intel-wired-lan] [PATCH RFC net-next 0/1] idpf: add IDPF driver for initial feedback

[Intel-wired-lan] [PATCH RFC net-next 0/1] idpf: add IDPF driver for initial feedback

[Pavan Kumar Linga]

This adds the Infrastructure Data Path Function (IDPF) driver
code as a single RFC patch. The main idea is to introduce the
IDPF driver just for initial feedback while this code is being
prepared into a proper series to be submitted to the mailing list
i.e. this patch is not intended to be merged but to get the feedback.

IDPF driver is used for both physical and virtual functions.
Except for some of the device operations, rest of the functionality
is same for both PF and VF. It uses virtchnl version2 opcodes and
structures defined in 'virtchnl2' header file which helps the driver
to learn most of the capabilities and register offsets from the
device Control Plane (CP) instead of assuming the default values.

Pavan Kumar Linga (1):
  idpf: introduce IDPF driver

 drivers/net/ethernet/intel/Makefile           |    1 +
 drivers/net/ethernet/intel/idpf/Makefile      |   20 +
 drivers/net/ethernet/intel/idpf/idpf.h        |  847 +++
 .../net/ethernet/intel/idpf/idpf_controlq.c   |  646 +++
 .../net/ethernet/intel/idpf/idpf_controlq.h   |  128 +
 .../ethernet/intel/idpf/idpf_controlq_api.h   |  190 +
 .../ethernet/intel/idpf/idpf_controlq_setup.c |  175 +
 drivers/net/ethernet/intel/idpf/idpf_dev.c    |  212 +
 drivers/net/ethernet/intel/idpf/idpf_devids.h |   10 +
 .../net/ethernet/intel/idpf/idpf_ethtool.c    | 1477 +++++
 .../ethernet/intel/idpf/idpf_lan_pf_regs.h    |  136 +
 .../net/ethernet/intel/idpf/idpf_lan_txrx.h   |  422 ++
 .../ethernet/intel/idpf/idpf_lan_vf_regs.h    |  119 +
 drivers/net/ethernet/intel/idpf/idpf_lib.c    | 2663 +++++++++
 drivers/net/ethernet/intel/idpf/idpf_main.c   |  128 +
 drivers/net/ethernet/intel/idpf/idpf_mem.h    |   20 +
 .../ethernet/intel/idpf/idpf_singleq_txrx.c   | 1331 +++++
 drivers/net/ethernet/intel/idpf/idpf_txrx.c   | 4937 +++++++++++++++++
 drivers/net/ethernet/intel/idpf/idpf_txrx.h   |  852 +++
 drivers/net/ethernet/intel/idpf/idpf_vf_dev.c |  195 +
 .../net/ethernet/intel/idpf/idpf_virtchnl.c   | 3980 +++++++++++++
 include/linux/avf/virtchnl2.h                 | 1490 +++++
 include/linux/avf/virtchnl2_lan_desc.h        |  605 ++
 23 files changed, 20584 insertions(+)
 create mode 100644 drivers/net/ethernet/intel/idpf/Makefile
 create mode 100644 drivers/net/ethernet/intel/idpf/idpf.h
 create mode 100644 drivers/net/ethernet/intel/idpf/idpf_controlq.c
 create mode 100644 drivers/net/ethernet/intel/idpf/idpf_controlq.h
 create mode 100644 drivers/net/ethernet/intel/idpf/idpf_controlq_api.h
 create mode 100644 drivers/net/ethernet/intel/idpf/idpf_controlq_setup.c
 create mode 100644 drivers/net/ethernet/intel/idpf/idpf_dev.c
 create mode 100644 drivers/net/ethernet/intel/idpf/idpf_devids.h
 create mode 100644 drivers/net/ethernet/intel/idpf/idpf_ethtool.c
 create mode 100644 drivers/net/ethernet/intel/idpf/idpf_lan_pf_regs.h
 create mode 100644 drivers/net/ethernet/intel/idpf/idpf_lan_txrx.h
 create mode 100644 drivers/net/ethernet/intel/idpf/idpf_lan_vf_regs.h
 create mode 100644 drivers/net/ethernet/intel/idpf/idpf_lib.c
 create mode 100644 drivers/net/ethernet/intel/idpf/idpf_main.c
 create mode 100644 drivers/net/ethernet/intel/idpf/idpf_mem.h
 create mode 100644 drivers/net/ethernet/intel/idpf/idpf_singleq_txrx.c
 create mode 100644 drivers/net/ethernet/intel/idpf/idpf_txrx.c
 create mode 100644 drivers/net/ethernet/intel/idpf/idpf_txrx.h
 create mode 100644 drivers/net/ethernet/intel/idpf/idpf_vf_dev.c
 create mode 100644 drivers/net/ethernet/intel/idpf/idpf_virtchnl.c
 create mode 100644 include/linux/avf/virtchnl2.h
 create mode 100644 include/linux/avf/virtchnl2_lan_desc.h

-- 
2.37.3

_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan

Re: [Intel-wired-lan] [PATCH RFC net-next 0/1] idpf: add IDPF driver for initial feedback

[Alexander Lobakin]

From: Pavan Kumar Linga <pavan.kumar.linga@intel.com>
Date: Wed, 23 Nov 2022 15:19:26 -0500

> This adds the Infrastructure Data Path Function (IDPF) driver
> code as a single RFC patch. The main idea is to introduce the
> IDPF driver just for initial feedback while this code is being
> prepared into a proper series to be submitted to the mailing list
> i.e. this patch is not intended to be merged but to get the feedback.
> 
> IDPF driver is used for both physical and virtual functions.
> Except for some of the device operations, rest of the functionality
> is same for both PF and VF. It uses virtchnl version2 opcodes and
> structures defined in 'virtchnl2' header file which helps the driver
> to learn most of the capabilities and register offsets from the
> device Control Plane (CP) instead of assuming the default values.

Eeeeh, how came you completely ignored all the already existing
comments from the internal MLs and didn't even provide a proper
series to review there internally, not speaking of sending a 20k+
chunk to IWL, which is a part of LKML? Are you aware LKML rejects
messages containing more than a couple thousand lines? LKML is not
the internal MLs to throw raw diffs or poor quality patches at.
You know the rules of submitting networking patches, right? Which
are the same for all the Intel networking folks? Why do you
deliberately violate them then? I haven't seen a word in those
rules saying "you can ignore this if your deadline is coming".

> 
> Pavan Kumar Linga (1):
>   idpf: introduce IDPF driver

[...]

> -- 
> 2.37.3

Thanks,
Olek
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan