* [Intel-wired-lan] [PATCH net-next] ice: Do not use WQ_MEM_RECLAIM flag for workqueue
@ 2022-11-30 12:34 Marcin Szycik
2022-11-30 19:50 ` Tony Nguyen
0 siblings, 1 reply; 3+ messages in thread
From: Marcin Szycik @ 2022-11-30 12:34 UTC (permalink / raw)
To: intel-wired-lan; +Cc: mustafa.ismail, shiraz.saleem
When both ice and the irdma driver are loaded, a warning
in check_flush_dependency is being triggered. This seems
to be because of the ice driver workqueue is allocated with
the WQ_MEM_RECLAIM flag, and the irdma one is not.
Looking at the kernel documentation, it doesn't seem like
the ice driver needs to use WQ_MEM_RECLAIM. Remove it.
Signed-off-by: Anirudh Venkataramanan <anirudh.venkataramanan@intel.com>
Signed-off-by: Marcin Szycik <marcin.szycik@linux.intel.com>
---
drivers/net/ethernet/intel/ice/ice_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/intel/ice/ice_main.c b/drivers/net/ethernet/intel/ice/ice_main.c
index 69984fea7fce..d01d1073ffec 100644
--- a/drivers/net/ethernet/intel/ice/ice_main.c
+++ b/drivers/net/ethernet/intel/ice/ice_main.c
@@ -5617,7 +5617,7 @@ static int __init ice_module_init(void)
pr_info("%s\n", ice_driver_string);
pr_info("%s\n", ice_copyright);
- ice_wq = alloc_workqueue("%s", WQ_MEM_RECLAIM, 0, KBUILD_MODNAME);
+ ice_wq = alloc_workqueue("%s", 0, 0, KBUILD_MODNAME);
if (!ice_wq) {
pr_err("Failed to create workqueue\n");
return -ENOMEM;
--
2.38.1
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [Intel-wired-lan] [PATCH net-next] ice: Do not use WQ_MEM_RECLAIM flag for workqueue
2022-11-30 12:34 [Intel-wired-lan] [PATCH net-next] ice: Do not use WQ_MEM_RECLAIM flag for workqueue Marcin Szycik
@ 2022-11-30 19:50 ` Tony Nguyen
2022-12-01 9:31 ` Marcin Szycik
0 siblings, 1 reply; 3+ messages in thread
From: Tony Nguyen @ 2022-11-30 19:50 UTC (permalink / raw)
To: Marcin Szycik, intel-wired-lan, Anirudh Venkataramanan
Cc: mustafa.ismail, shiraz.saleem
On 11/30/2022 4:34 AM, Marcin Szycik wrote:
I believe Ani is the author for this? I don't see him as the author though.
i.e.
From: Anirudh Venkataramanan <anirudh.venkataramanan@intel.com>
> When both ice and the irdma driver are loaded, a warning
> in check_flush_dependency is being triggered. This seems
> to be because of the ice driver workqueue is allocated with
> the WQ_MEM_RECLAIM flag, and the irdma one is not.
>
> Looking at the kernel documentation, it doesn't seem like
> the ice driver needs to use WQ_MEM_RECLAIM. Remove it.
>
> Signed-off-by: Anirudh Venkataramanan <anirudh.venkataramanan@intel.com>
> Signed-off-by: Marcin Szycik <marcin.szycik@linux.intel.com>
> ---
> drivers/net/ethernet/intel/ice/ice_main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/intel/ice/ice_main.c b/drivers/net/ethernet/intel/ice/ice_main.c
> index 69984fea7fce..d01d1073ffec 100644
> --- a/drivers/net/ethernet/intel/ice/ice_main.c
> +++ b/drivers/net/ethernet/intel/ice/ice_main.c
> @@ -5617,7 +5617,7 @@ static int __init ice_module_init(void)
> pr_info("%s\n", ice_driver_string);
> pr_info("%s\n", ice_copyright);
>
> - ice_wq = alloc_workqueue("%s", WQ_MEM_RECLAIM, 0, KBUILD_MODNAME);
> + ice_wq = alloc_workqueue("%s", 0, 0, KBUILD_MODNAME);
> if (!ice_wq) {
> pr_err("Failed to create workqueue\n");
> return -ENOMEM;
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [Intel-wired-lan] [PATCH net-next] ice: Do not use WQ_MEM_RECLAIM flag for workqueue
2022-11-30 19:50 ` Tony Nguyen
@ 2022-12-01 9:31 ` Marcin Szycik
0 siblings, 0 replies; 3+ messages in thread
From: Marcin Szycik @ 2022-12-01 9:31 UTC (permalink / raw)
To: Tony Nguyen, intel-wired-lan, Anirudh Venkataramanan
Cc: mustafa.ismail, shiraz.saleem
Sorry, my bad. I'll send v2.
On 30.11.2022 20:50, Tony Nguyen wrote:
>
>
> On 11/30/2022 4:34 AM, Marcin Szycik wrote:
>
> I believe Ani is the author for this? I don't see him as the author though.
>
> i.e.
> From: Anirudh Venkataramanan <anirudh.venkataramanan@intel.com>
>
>> When both ice and the irdma driver are loaded, a warning
>> in check_flush_dependency is being triggered. This seems
>> to be because of the ice driver workqueue is allocated with
>> the WQ_MEM_RECLAIM flag, and the irdma one is not.
>>
>> Looking at the kernel documentation, it doesn't seem like
>> the ice driver needs to use WQ_MEM_RECLAIM. Remove it.
>>
>> Signed-off-by: Anirudh Venkataramanan <anirudh.venkataramanan@intel.com>
>> Signed-off-by: Marcin Szycik <marcin.szycik@linux.intel.com>
>> ---
>> drivers/net/ethernet/intel/ice/ice_main.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/net/ethernet/intel/ice/ice_main.c b/drivers/net/ethernet/intel/ice/ice_main.c
>> index 69984fea7fce..d01d1073ffec 100644
>> --- a/drivers/net/ethernet/intel/ice/ice_main.c
>> +++ b/drivers/net/ethernet/intel/ice/ice_main.c
>> @@ -5617,7 +5617,7 @@ static int __init ice_module_init(void)
>> pr_info("%s\n", ice_driver_string);
>> pr_info("%s\n", ice_copyright);
>> - ice_wq = alloc_workqueue("%s", WQ_MEM_RECLAIM, 0, KBUILD_MODNAME);
>> + ice_wq = alloc_workqueue("%s", 0, 0, KBUILD_MODNAME);
>> if (!ice_wq) {
>> pr_err("Failed to create workqueue\n");
>> return -ENOMEM;
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-12-01 9:32 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-11-30 12:34 [Intel-wired-lan] [PATCH net-next] ice: Do not use WQ_MEM_RECLAIM flag for workqueue Marcin Szycik
2022-11-30 19:50 ` Tony Nguyen
2022-12-01 9:31 ` Marcin Szycik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox