Intel-Wired-Lan Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Jan Sokolowski <jan.sokolowski@intel.com>
To: intel-wired-lan@lists.osuosl.org
Subject: [Intel-wired-lan] [PATCH iwl-next v3 7/7] ice: refactor ice_vsi_is_vlan_pruning_ena
Date: Wed,  9 Aug 2023 15:39:13 +0200	[thread overview]
Message-ID: <20230809133913.2652736-8-jan.sokolowski@intel.com> (raw)
In-Reply-To: <20230809133913.2652736-1-jan.sokolowski@intel.com>

As this method became static, and is already called
with check for vsi being non-null, an unnecessary check along
with superfluous parentheses is removed.

Signed-off-by: Jan Sokolowski <jan.sokolowski@intel.com>
---
 drivers/net/ethernet/intel/ice/ice_lib.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/net/ethernet/intel/ice/ice_lib.c b/drivers/net/ethernet/intel/ice/ice_lib.c
index d3fb2b7535e7..201570cd2e0b 100644
--- a/drivers/net/ethernet/intel/ice/ice_lib.c
+++ b/drivers/net/ethernet/intel/ice/ice_lib.c
@@ -1235,10 +1235,7 @@ ice_chnl_vsi_setup_q_map(struct ice_vsi *vsi, struct ice_vsi_ctx *ctxt)
  */
 static bool ice_vsi_is_vlan_pruning_ena(struct ice_vsi *vsi)
 {
-	if (!vsi)
-		return false;
-
-	return (vsi->info.sw_flags2 & ICE_AQ_VSI_SW_FLAG_RX_VLAN_PRUNE_ENA);
+	return vsi->info.sw_flags2 & ICE_AQ_VSI_SW_FLAG_RX_VLAN_PRUNE_ENA;
 }
 
 /**
-- 
2.31.1

_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan

  parent reply	other threads:[~2023-08-09 13:36 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-09 13:39 [Intel-wired-lan] [PATCH iwl-next v3 0/7] ice: staticization refactor Jan Sokolowski
2023-08-09 13:39 ` [Intel-wired-lan] [PATCH iwl-next v3 1/7] ice: remove unused methods Jan Sokolowski
2023-08-09 13:39 ` [Intel-wired-lan] [PATCH iwl-next v3 2/7] ice: refactor ice_ddp to make functions static Jan Sokolowski
2023-08-09 13:39 ` [Intel-wired-lan] [PATCH iwl-next v3 3/7] ice: refactor ice_lib " Jan Sokolowski
2023-08-09 13:39 ` [Intel-wired-lan] [PATCH iwl-next v3 4/7] ice: refactor ice_vf_lib " Jan Sokolowski
2023-08-09 13:39 ` [Intel-wired-lan] [PATCH iwl-next v3 5/7] ice: refactor ice_sched " Jan Sokolowski
2023-08-09 13:39 ` [Intel-wired-lan] [PATCH iwl-next v3 6/7] ice: refactor ice_ptp_hw " Jan Sokolowski
2023-08-09 13:39 ` Jan Sokolowski [this message]
2023-08-09 17:29 ` [Intel-wired-lan] [PATCH iwl-next v3 0/7] ice: staticization refactor Jacob Keller
2023-08-10 11:11 ` Przemek Kitszel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230809133913.2652736-8-jan.sokolowski@intel.com \
    --to=jan.sokolowski@intel.com \
    --cc=intel-wired-lan@lists.osuosl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox