Re: [Intel-wired-lan] [PATCH iwl-next v3 0/7] ice: staticization refactor

[Jacob Keller <jacob.e.keller@intel.com>]

On 8/9/2023 6:39 AM, Jan Sokolowski wrote:
> ice: refactor methods to make them static
> 
> This series of patches refactor some ice driver files
> in order to make as many methods as possible static.
> One additional patch introduced in v3 also refactors
> one method that can be simplified thanks to being
> static.
> 
> Also there's a minor cleanup of unused methods.
> 
> Jan Sokolowski (7):
>   ice: remove unused methods
>   ice: refactor ice_ddp to make functions static
>   ice: refactor ice_lib to make functions static
>   ice: refactor ice_vf_lib to make functions static
>   ice: refactor ice_sched to make functions static
>   ice: refactor ice_ptp_hw to make functions static
>   ice: refactor ice_vsi_is_vlan_pruning_ena
> 

I read through this and it all seems reasonable. Some of the code in
ice_vf_lib.c used to be called from other files but later refactors have
since eliminated those calls.

Additionally the read PHY register functions in ice_ptp_hw.c also were
previously called in other files but no longer.

Thanks for the cleanup.

Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>

>  drivers/net/ethernet/intel/ice/ice_ddp.c      | 120 ++---
>  drivers/net/ethernet/intel/ice/ice_ddp.h      |  10 -
>  drivers/net/ethernet/intel/ice/ice_lib.c      |  82 ++-
>  drivers/net/ethernet/intel/ice/ice_lib.h      |   5 -
>  drivers/net/ethernet/intel/ice/ice_ptp_hw.c   |  25 +-
>  drivers/net/ethernet/intel/ice/ice_ptp_hw.h   |   4 -
>  drivers/net/ethernet/intel/ice/ice_sched.c    |   2 +-
>  drivers/net/ethernet/intel/ice/ice_sched.h    |   4 -
>  drivers/net/ethernet/intel/ice/ice_switch.c   |  48 --
>  drivers/net/ethernet/intel/ice/ice_switch.h   |   1 -
>  drivers/net/ethernet/intel/ice/ice_vf_lib.c   | 468 +++++++++---------
>  .../ethernet/intel/ice/ice_vf_lib_private.h   |   2 -
>  12 files changed, 331 insertions(+), 440 deletions(-)
> 
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan