From: christopher.s.hall@intel.com
To: intel-wired-lan@lists.osuosl.org
Cc: Christopher S M Hall <christopher.s.hall@intel.com>,
david.zage@intel.com, vinschen@redhat.com,
vinicius.gomes@intel.com, netdev@vger.kernel.org,
rodrigo.cadore@l-acoustics.com
Subject: [Intel-wired-lan] [PATCH iwl-net v1 0/5] igc: PTM timeout fix
Date: Tue, 6 Aug 2024 17:30:27 -0700 [thread overview]
Message-ID: <20240807003032.10300-1-christopher.s.hall@intel.com> (raw)
From: Christopher S M Hall <christopher.s.hall@intel.com>
There have been sporadic reports of PTM timeouts using i225/i226 devices
These timeouts have been root caused to:
1) Manipulating the PTM status register while PTM is enabled and triggered
2) The hardware retrying too quickly when an inappropriate response is
received from the upstream device
The issue can be reproduced with the following:
$ sudo phc2sys -R 1000 -O 0 -i tsn0 -m
Note: 1000 Hz (-R 1000) is unrealistically large, but provides a way to
quickly reproduce the issue.
PHC2SYS exits with:
"ioctl PTP_OFFSET_PRECISE: Connection timed out" when the PTM transaction
fails
Christopher S M Hall (5):
igc: Ensure the PTM cycle is reliably triggered
igc: Lengthen the hardware retry time to prevent timeouts
igc: Move ktime snapshot into PTM retry loop
igc: Reduce retry count to a more reasonable number
igc: Add lock preventing multiple simultaneous PTM transactions
drivers/net/ethernet/intel/igc/igc.h | 1 +
drivers/net/ethernet/intel/igc/igc_defines.h | 3 +-
drivers/net/ethernet/intel/igc/igc_ptp.c | 100 +++++++++++--------
3 files changed, 63 insertions(+), 41 deletions(-)
--
2.34.1
next reply other threads:[~2024-08-07 0:36 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-07 0:30 christopher.s.hall [this message]
2024-08-07 0:30 ` [Intel-wired-lan] [PATCH iwl-net v1 1/5] igc: Ensure the PTM cycle is reliably triggered christopher.s.hall
2024-08-07 5:05 ` Paul Menzel
2024-08-07 16:15 ` Corinna Vinschen
2024-08-07 20:27 ` Hall, Christopher S
2024-08-08 14:50 ` Corinna Vinschen
2024-08-07 0:30 ` [Intel-wired-lan] [PATCH iwl-net v1 2/5] igc: Lengthen the hardware retry time to prevent timeouts christopher.s.hall
2024-08-08 14:54 ` Corinna Vinschen
2024-08-07 0:30 ` [Intel-wired-lan] [PATCH iwl-net v1 3/5] igc: Move ktime snapshot into PTM retry loop christopher.s.hall
2024-08-08 14:54 ` Corinna Vinschen
2024-08-07 0:30 ` [Intel-wired-lan] [PATCH iwl-net v1 4/5] igc: Reduce retry count to a more reasonable number christopher.s.hall
2024-08-07 5:28 ` Paul Menzel
2024-08-07 0:30 ` [Intel-wired-lan] [PATCH iwl-net v1 5/5] igc: Add lock preventing multiple simultaneous PTM transactions christopher.s.hall
2024-08-08 15:17 ` Corinna Vinschen
2024-10-11 9:25 ` [Intel-wired-lan] [PATCH iwl-net v1 0/5] igc: PTM timeout fix Corinna Vinschen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240807003032.10300-1-christopher.s.hall@intel.com \
--to=christopher.s.hall@intel.com \
--cc=david.zage@intel.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=netdev@vger.kernel.org \
--cc=rodrigo.cadore@l-acoustics.com \
--cc=vinicius.gomes@intel.com \
--cc=vinschen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox