* [Intel-wired-lan] [PATCH iwl-next v1] igb: remove ASSERT_RTNL() from igb_write_rss_key()
@ 2026-07-11 13:32 Takashi Kozu
2026-07-20 10:20 ` Simon Horman
0 siblings, 1 reply; 2+ messages in thread
From: Takashi Kozu @ 2026-07-11 13:32 UTC (permalink / raw)
To: anthony.l.nguyen
Cc: przemyslaw.kitszel, andrew+netdev, davem, edumazet, kuba, pabeni,
intel-wired-lan, netdev, kohei.enju, Takashi Kozu
igb_runtime_resume() calls __igb_resume() with rpm=true, which
skips rtnl_lock() to avoid deadlocks. On that path __igb_open()
-> igb_configure() -> igb_setup_mrqc() -> igb_write_rss_key()
runs without rtnl held, so ASSERT_RTNL() fires a false-positive
WARN on every runtime resume. Drop it.
Fixes: dfaf57ef99cf ("igb: prepare for RSS key get/set support")
Signed-off-by: Takashi Kozu <takkozu@amazon.com>
---
drivers/net/ethernet/intel/igb/igb_ethtool.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/net/ethernet/intel/igb/igb_ethtool.c b/drivers/net/ethernet/intel/igb/igb_ethtool.c
index 65014a54a6d1..4eb586f9af99 100644
--- a/drivers/net/ethernet/intel/igb/igb_ethtool.c
+++ b/drivers/net/ethernet/intel/igb/igb_ethtool.c
@@ -3031,8 +3031,6 @@ void igb_write_rss_key(struct igb_adapter *adapter)
{
struct e1000_hw *hw = &adapter->hw;
- ASSERT_RTNL();
-
for (int i = 0; i < IGB_RSS_KEY_SIZE / 4; i++) {
u32 val = get_unaligned_le32(&adapter->rss_key[i * 4]);
--
2.54.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Intel-wired-lan] [PATCH iwl-next v1] igb: remove ASSERT_RTNL() from igb_write_rss_key()
2026-07-11 13:32 [Intel-wired-lan] [PATCH iwl-next v1] igb: remove ASSERT_RTNL() from igb_write_rss_key() Takashi Kozu
@ 2026-07-20 10:20 ` Simon Horman
0 siblings, 0 replies; 2+ messages in thread
From: Simon Horman @ 2026-07-20 10:20 UTC (permalink / raw)
To: Takashi Kozu
Cc: anthony.l.nguyen, przemyslaw.kitszel, andrew+netdev, davem,
edumazet, kuba, pabeni, intel-wired-lan, netdev, kohei.enju
On Sat, Jul 11, 2026 at 10:32:15PM +0900, Takashi Kozu wrote:
> igb_runtime_resume() calls __igb_resume() with rpm=true, which
> skips rtnl_lock() to avoid deadlocks. On that path __igb_open()
> -> igb_configure() -> igb_setup_mrqc() -> igb_write_rss_key()
> runs without rtnl held, so ASSERT_RTNL() fires a false-positive
> WARN on every runtime resume. Drop it.
Hi Takashi,
I think this patch description needs to explain why
it is safe to run igb_write_rss_key() without holding RTNL.
>
> Fixes: dfaf57ef99cf ("igb: prepare for RSS key get/set support")
> Signed-off-by: Takashi Kozu <takkozu@amazon.com>
...
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-07-20 10:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-07-11 13:32 [Intel-wired-lan] [PATCH iwl-next v1] igb: remove ASSERT_RTNL() from igb_write_rss_key() Takashi Kozu
2026-07-20 10:20 ` Simon Horman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox