From: Li,Rongqing <lirongqing@baidu.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [bug ?] i40e_rx_buffer_flip should not be called for redirected xsk copy mode
Date: Thu, 2 Jul 2020 09:17:49 +0000 [thread overview]
Message-ID: <2863b548da1d4c369bbd9d6ceb337a24@baidu.com> (raw)
Hi:
i40e_rx_buffer_flip to xsk copy mode can lead to data corruption, like the following flow:
1. first skb is not for xsk, and forwarded to another device or socket queue
2. seconds skb is for xsk, copy data to xsk memory, and page of skb->data is released
3. rx_buff is reusable since only first skb is in it, but i40e_rx_buffer_flip will make that page_offset is set to first skb data
4. then reuse rx buffer, first skb which still is living will be corrupted.
-Li RongQing
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osuosl.org/pipermail/intel-wired-lan/attachments/20200702/810347e7/attachment.html>
next reply other threads:[~2020-07-02 9:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-02 9:17 Li, Rongqing [this message]
2020-07-06 6:13 ` [Intel-wired-lan] [bug ?] i40e_rx_buffer_flip should not be called for redirected xsk copy mode Magnus Karlsson
2020-07-14 11:05 ` [Intel-wired-lan] 答复: " Li, Rongqing
2020-07-16 4:39 ` [Intel-wired-lan] " Magnus Karlsson
2020-07-16 5:33 ` [Intel-wired-lan] 答复: " Li, Rongqing
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2863b548da1d4c369bbd9d6ceb337a24@baidu.com \
--to=lirongqing@baidu.com \
--cc=intel-wired-lan@osuosl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox