[Intel-wired-lan] [bug ?] i40e_rx_buffer_flip should not be called for redirected xsk copy mode

[Intel-wired-lan] [bug ?] i40e_rx_buffer_flip should not be called for redirected xsk copy mode

[Li, Rongqing]

Hi:

i40e_rx_buffer_flip to xsk copy mode can lead to data corruption, like the following flow:

1. first skb is not for xsk, and forwarded to another device or socket queue
2. seconds skb is for xsk, copy data to xsk memory, and page of skb->data is released
3. rx_buff is reusable since only first skb is in it, but i40e_rx_buffer_flip will make that page_offset is set to first skb data
4. then reuse rx buffer, first skb which still is living will be corrupted.

-Li RongQing

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osuosl.org/pipermail/intel-wired-lan/attachments/20200702/810347e7/attachment.html>

[Intel-wired-lan] [bug ?] i40e_rx_buffer_flip should not be called for redirected xsk copy mode

[Magnus Karlsson]

Thank you RongQing for reporting this. I will take a look at it and
produce a patch.

/Magnus

On Thu, Jul 2, 2020 at 11:33 AM Li,Rongqing <lirongqing@baidu.com> wrote:
>
> Hi:
>
>
>
> i40e_rx_buffer_flip to xsk copy mode can lead to data corruption, like the following flow:
>
>
>
> 1. first skb is not for xsk, and forwarded to another device or socket queue
>
> 2. seconds skb is for xsk, copy data to xsk memory, and page of skb->data is released
>
> 3. rx_buff is reusable since only first skb is in it, but i40e_rx_buffer_flip will make that page_offset is set to first skb data
>
> 4. then reuse rx buffer, first skb which still is living will be corrupted.
>
>
>
> -Li RongQing
>
>
>
> _______________________________________________
> Intel-wired-lan mailing list
> Intel-wired-lan at osuosl.org
> https://lists.osuosl.org/mailman/listinfo/intel-wired-lan

[Intel-wired-lan] 答复: [bug ?] i40e_rx_buffer_flip should not be called for redirected xsk copy mode

[Li, Rongqing]

> -----????-----
> ???: Li,Rongqing
> ????: 2020?7?6? 14:38
> ???: 'Magnus Karlsson' <magnus.karlsson@gmail.com>
> ??: intel-wired-lan <intel-wired-lan@lists.osuosl.org>; Bj?rn T?pel
> <bjorn.topel@intel.com>; Karlsson, Magnus <magnus.karlsson@intel.com>;
> Netdev <netdev@vger.kernel.org>
> ??: ??: [Intel-wired-lan] [bug ?] i40e_rx_buffer_flip should not be called
> for redirected xsk copy mode
> 
> 
> 
> > -----????-----
> > ???: Magnus Karlsson [mailto:magnus.karlsson at gmail.com]
> > ????: 2020?7?6? 14:13
> > ???: Li,Rongqing <lirongqing@baidu.com>
> > ??: intel-wired-lan <intel-wired-lan@lists.osuosl.org>; Bj?rn T?pel
> > <bjorn.topel@intel.com>; Karlsson, Magnus <magnus.karlsson@intel.com>;
> > Netdev <netdev@vger.kernel.org>
> > ??: Re: [Intel-wired-lan] [bug ?] i40e_rx_buffer_flip should not be
> > called for redirected xsk copy mode
> >
> > Thank you RongQing for reporting this. I will take a look at it and
> > produce a patch.
> >
> > /Magnus
> 

Ping


-Li

[Intel-wired-lan] [bug ?] i40e_rx_buffer_flip should not be called for redirected xsk copy mode

[Magnus Karlsson]

On Tue, Jul 14, 2020 at 1:05 PM Li,Rongqing <lirongqing@baidu.com> wrote:
>
>
>
> > -----????-----
> > ???: Li,Rongqing
> > ????: 2020?7?6? 14:38
> > ???: 'Magnus Karlsson' <magnus.karlsson@gmail.com>
> > ??: intel-wired-lan <intel-wired-lan@lists.osuosl.org>; Bj?rn T?pel
> > <bjorn.topel@intel.com>; Karlsson, Magnus <magnus.karlsson@intel.com>;
> > Netdev <netdev@vger.kernel.org>
> > ??: ??: [Intel-wired-lan] [bug ?] i40e_rx_buffer_flip should not be called
> > for redirected xsk copy mode
> >
> >
> >
> > > -----????-----
> > > ???: Magnus Karlsson [mailto:magnus.karlsson at gmail.com]
> > > ????: 2020?7?6? 14:13
> > > ???: Li,Rongqing <lirongqing@baidu.com>
> > > ??: intel-wired-lan <intel-wired-lan@lists.osuosl.org>; Bj?rn T?pel
> > > <bjorn.topel@intel.com>; Karlsson, Magnus <magnus.karlsson@intel.com>;
> > > Netdev <netdev@vger.kernel.org>
> > > ??: Re: [Intel-wired-lan] [bug ?] i40e_rx_buffer_flip should not be
> > > called for redirected xsk copy mode
> > >
> > > Thank you RongQing for reporting this. I will take a look at it and
> > > produce a patch.
> > >
> > > /Magnus
> >
>
> Ping

My apologies RongQing, but it is taking longer than expected due to
key people being on vacation during this summer period. We are
debating weather the simple fix you provided covers all cases.
Hopefully it does, but we just want to make sure. The fix is needed in
four drivers: the ones you mention plus ice.

/Magnus

>
> -Li

[Intel-wired-lan] 答复: [bug ?] i40e_rx_buffer_flip should not be called for redirected xsk copy mode

[Li, Rongqing]

> > > >
> > > > Thank you RongQing for reporting this. I will take a look at it
> > > > and produce a patch.
> > > >
> > > > /Magnus
> > >
> >
> > Ping
> 
> My apologies RongQing, but it is taking longer than expected due to key people
> being on vacation during this summer period. We are debating weather the
> simple fix you provided covers all cases.
> Hopefully it does, but we just want to make sure. The fix is needed in four
> drivers: the ones you mention plus ice.
> 
> /Magnus

If my RFC patch is suitable for this bug, I will resend it.

should I send four patches for four drivers, or should I send one patch for them?


Thanks

-Li