From: "Ruinskiy, Dima" <dima.ruinskiy@intel.com>
To: Timo Teras <timo.teras@iki.fi>
Cc: Vitaly Lifshits <vitaly.lifshits@intel.com>,
Todd Brandt <todd.e.brandt@intel.com>,
David Box <david.e.box@linux.intel.com>,
Len Brown <lenb@kernel.org>, <intel-wired-lan@lists.osuosl.org>,
<marmarek@invisiblethingslab.com>, <jeremie.wenger@edu.ge.ch>
Subject: Re: [Intel-wired-lan] [PATCH iwl-net v2 1/1] e1000e: reconfigure PLL clock gate value and re-enable K1 on Meteor Lake
Date: Sun, 22 Feb 2026 18:05:12 +0200 [thread overview]
Message-ID: <29b8a4b4-66d4-47e5-a316-b88a03b3882c@intel.com> (raw)
In-Reply-To: <20260212111506.16bc402a@onyx.my.domain>
On 12/02/2026 11:15, Timo Teras wrote:
> Is there other PLL timeout value to test?
Some preliminary calculations we did suggest that raising the value a
bit further - from 0x1D5 to 0x226 - might be worthwhile. Beyond that you
may run into other issues.
If you can try it on your machine and report back, that would be great.
Currently, the only similar system I have is a Pro Max 16 with a U9-285H
CPU. It is the same SoC generation, but many components are different,
and I cannot even get the original issue to reproduce there.
> There was also never reply to the question on how likely / large issue
> the potential Rx packet drop is? How many units it may affect?
>
> From the earlier discussion we know that the "network does not work
> after cable unplug/plug" issue this causes is affecting multiple different
> vendors and is a *major* problem.
I do not have exact numbers, but it is definitely true that multiple
system from different vendors have suffered from it.
> If you end up changing K1 default, please add a mechanism to add
> quirks on how to disable it on affected systems without needing user
> space configuration. I find it unacceptable that userspace needs to
> be modified to fix kernel driver behavior on known bad devices.
I have been pondering something like a DMI quirk. These have been
proposed before for various issues, e.g.:
https://patchwork.ozlabs.org/project/intel-wired-lan/patch/20200319052629.7282-1-kai.heng.feng@canonical.com/
Back then we found a better solution, so this approach was dropped. The
basic idea can be used as a mechanism for a table of "known bad"
devices, which the driver can check against to determine the default value.
However, I do not have the capacity to maintain the table itself, or
even validate every device someone might want to add to it.
At one point there was a proposition to introduce such a table of quirks
to a Realtek network driver, which was also ultimately rejected from
upstream (note specifically the comments at the end of the thread):
https://patchew.org/linux/20241208191039.2240-1-guyc.linux.patches@gmail.com/
Thanks!
--Dima
next prev parent reply other threads:[~2026-02-22 16:05 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-02 10:32 [Intel-wired-lan] [PATCH iwl-net v2 1/1] e1000e: reconfigure PLL clock gate value and re-enable K1 on Meteor Lake Vitaly Lifshits
2026-02-02 12:09 ` Loktionov, Aleksandr
2026-02-10 10:57 ` Dahan, AvigailX
2026-02-10 11:11 ` Timo Teras
2026-02-11 13:11 ` Ruinskiy, Dima
2026-02-12 9:15 ` Timo Teras
2026-02-22 16:05 ` Ruinskiy, Dima [this message]
2026-02-26 12:36 ` Timo Teras
2026-03-25 15:49 ` Ruinskiy, Dima
2026-04-01 7:07 ` Ruinskiy, Dima
2026-04-01 7:25 ` Timo Teras
2026-04-01 8:19 ` Ruinskiy, Dima
2026-04-19 5:54 ` Ruinskiy, Dima
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=29b8a4b4-66d4-47e5-a316-b88a03b3882c@intel.com \
--to=dima.ruinskiy@intel.com \
--cc=david.e.box@linux.intel.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jeremie.wenger@edu.ge.ch \
--cc=lenb@kernel.org \
--cc=marmarek@invisiblethingslab.com \
--cc=timo.teras@iki.fi \
--cc=todd.e.brandt@intel.com \
--cc=vitaly.lifshits@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox