From: "Ruinskiy, Dima" <dima.ruinskiy@intel.com>
To: Timo Teras <timo.teras@iki.fi>
Cc: "Lifshits, Vitaly" <vitaly.lifshits@intel.com>,
"Brandt, Todd E" <todd.e.brandt@intel.com>,
David Box <david.e.box@linux.intel.com>,
Len Brown <lenb@kernel.org>,
"intel-wired-lan@lists.osuosl.org"
<intel-wired-lan@lists.osuosl.org>,
"marmarek@invisiblethingslab.com"
<marmarek@invisiblethingslab.com>,
"jeremie.wenger@edu.ge.ch" <jeremie.wenger@edu.ge.ch>
Subject: Re: [Intel-wired-lan] [PATCH iwl-net v2 1/1] e1000e: reconfigure PLL clock gate value and re-enable K1 on Meteor Lake
Date: Wed, 1 Apr 2026 10:07:45 +0300 [thread overview]
Message-ID: <f39683ed-7397-40ec-ad0f-833664ea5c8b@intel.com> (raw)
In-Reply-To: <35bc35d8-ff5d-4596-9f9f-6ab563c890b0@intel.com>
On 25/03/2026 17:49, Ruinskiy, Dima wrote:
> On 26/02/2026 14:36, Timo Teras wrote:
>> Yes, generally maintaining a large quirk set is infeasible.
>>
>> But this is my point: if the affected set of machines with this issue
>> is so large that maintaining a quirk set becomes infeasible, then
>> the proposed change will make life very difficult for large enough
>> set of people that a better solution should be devised.
>>
>> Timo
>>
>>
> At this point, with the current PLL change, it looks like the number of
> affected systems would be smaller than would be with the previous PLL
> value.
>
> So far we have not received additional reports of regressions caused by
> this patch, other than yours. So, perhaps, the it can be manageable with
> a DMI quirk approach. I went ahead and implemented the infrastructure,
> it's actually quite a small change, and does what I want (automatically
> alters the default value of the K1 disable flag).
>
> Could you share the DMI IDs of your system, where the issue is observed?
> Most likely the sys_vendor, product_family and product_name, located
> under /sys/class/dmi/id would be the most useful. I can add them as an
> initial DMI table entry for v3 of this patch (or a follow-up patch).
>
> Thanks!
> --Dima
Hi Timo,
Just double-checking as a follow-up to my email last week.
We plan to send this patch upstream shortly, since the current situation
where the upstream kernel is unable to pass Energy Star certification
with the default settings is not acceptable.
If you want to share the DMI IDs of the problematic system I will go
ahead and add those in v3 or in a follow-up patch, so that K1 is
automatically disabled on that class of systems.
Thanks!
--Dima
next prev parent reply other threads:[~2026-04-01 7:08 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-02 10:32 [Intel-wired-lan] [PATCH iwl-net v2 1/1] e1000e: reconfigure PLL clock gate value and re-enable K1 on Meteor Lake Vitaly Lifshits
2026-02-02 12:09 ` Loktionov, Aleksandr
2026-02-10 10:57 ` Dahan, AvigailX
2026-02-10 11:11 ` Timo Teras
2026-02-11 13:11 ` Ruinskiy, Dima
2026-02-12 9:15 ` Timo Teras
2026-02-22 16:05 ` Ruinskiy, Dima
2026-02-26 12:36 ` Timo Teras
2026-03-25 15:49 ` Ruinskiy, Dima
2026-04-01 7:07 ` Ruinskiy, Dima [this message]
2026-04-01 7:25 ` Timo Teras
2026-04-01 8:19 ` Ruinskiy, Dima
2026-04-19 5:54 ` Ruinskiy, Dima
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f39683ed-7397-40ec-ad0f-833664ea5c8b@intel.com \
--to=dima.ruinskiy@intel.com \
--cc=david.e.box@linux.intel.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jeremie.wenger@edu.ge.ch \
--cc=lenb@kernel.org \
--cc=marmarek@invisiblethingslab.com \
--cc=timo.teras@iki.fi \
--cc=todd.e.brandt@intel.com \
--cc=vitaly.lifshits@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox