Re: [Intel-wired-lan] [PATCH net v2 2/4] ice: Ignore ERR_ALREADY_EXISTS when setting promisc mode

[Tony Nguyen <anthony.l.nguyen@intel.com>]

On 8/4/2022 7:20 AM, Grzegorz Siwik wrote:
> Ignore ERR_ALREADY_EXISTS error when setting promiscuous mode.

Isn't this EEXIST, not ERR_ALREADY_EXISTS?

> This fix is needed because the driver could set promiscuous mode
> when it still has not cleared properly.
> Promiscuous mode could be set only once, so setting it second
> time will be rejected.
> 
> Fixes: 5eda8afd6bcc ("ice: Add support for PF/VF promiscuous mode")
> Signed-off-by: Grzegorz Siwik <grzegorz.siwik@intel.com>
> Link:
> https://lore.kernel.org/all/CAK8fFZ7m-KR57M_rYX6xZN39K89O=LGooYkKsu6HKt0Bs+x6xQ@mail.gmail.com/

Please, no newline after Link:, keep it all on the same line. Same 
comment for all the other patches as well.

> ---
>   v2: Fixed error message when setting same promiscuous mode
> ---
>   drivers/net/ethernet/intel/ice/ice_switch.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/intel/ice/ice_switch.c b/drivers/net/ethernet/intel/ice/ice_switch.c
> index 8a60052..0aa4871 100644
> --- a/drivers/net/ethernet/intel/ice/ice_switch.c
> +++ b/drivers/net/ethernet/intel/ice/ice_switch.c
> @@ -4428,7 +4428,7 @@ static u8 ice_determine_promisc_mask(struct ice_fltr_info *fi)
>   		else
>   			status = ice_set_vsi_promisc(hw, vsi_handle,
>   						     promisc_mask, vlan_id);
> -		if (status)
> +		if (status && status != -EEXIST)
>   			break;
>   	}
>   
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan