From: Tony Nguyen <anthony.l.nguyen@intel.com>
To: Grzegorz Siwik <grzegorz.siwik@intel.com>,
<intel-wired-lan@lists.osuosl.org>
Cc: Benjamin Mikailenko <benjamin.mikailenko@intel.com>
Subject: Re: [Intel-wired-lan] [PATCH net v2 4/4] ice: Ignore error message when setting same promiscuous mode
Date: Fri, 5 Aug 2022 09:24:17 -0700 [thread overview]
Message-ID: <a3e37102-1f74-a9f4-d202-79c94add0afd@intel.com> (raw)
In-Reply-To: <1659622830-13292-5-git-send-email-grzegorz.siwik@intel.com>
On 8/4/2022 7:20 AM, Grzegorz Siwik wrote:
> From: Benjamin Mikailenko <benjamin.mikailenko@intel.com>
>
> Commit 1273f89578f2 ("ice-linux: Fix broken IFF_ALLMULTI handling")
ice-linux? Isn't this just "ice"?
> introduced new checks when setting/clearing promiscuous mode. But if the
> requested promiscuous mode setting already exists, an -EEXIST error
> message would be printed. This is incorrect because promiscuous mode is
> either on/off and shouldn't print an error when the requested
> configuration is already set.
>
> This can happen when removing a bridge with two bonded interfaces and
> promiscuous most isn't fully cleared from VLAN VSI in hardware.
>
> Fix this by ignoring cases where requested promiscuous mode exists.
>
> Fixes: 1273f89578f2 ("ice-linux: Fix broken IFF_ALLMULTI handling")
Which is also incorrect here:
Fixes tag: Fixes: 1273f89578f2 ("ice-linux: Fix broken IFF_ALLMULTI
handling")
Has these problem(s):
- Subject does not match target commit subject
> Signed-off-by: Benjamin Mikailenko <benjamin.mikailenko@intel.com>
> Signed-off-by: Grzegorz Siwik <grzegorz.siwik@intel.com>
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
prev parent reply other threads:[~2022-08-05 16:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-04 14:20 [Intel-wired-lan] [PATCH net v2 0/4] ice: Fixes for double vlan promiscuous mode Grzegorz Siwik
2022-08-04 14:20 ` [Intel-wired-lan] [PATCH net v2 1/4] ice: Fix double VLAN error when entering promisc mode Grzegorz Siwik
2022-08-04 14:20 ` [Intel-wired-lan] [PATCH net v2 2/4] ice: Ignore ERR_ALREADY_EXISTS when setting " Grzegorz Siwik
2022-08-05 16:17 ` Tony Nguyen
2022-08-04 14:20 ` [Intel-wired-lan] [PATCH net v2 3/4] ice: Fix clearing of promisc mode with bridge over bond Grzegorz Siwik
2022-08-05 16:20 ` Tony Nguyen
2022-08-04 14:20 ` [Intel-wired-lan] [PATCH net v2 4/4] ice: Ignore error message when setting same promiscuous mode Grzegorz Siwik
2022-08-05 16:24 ` Tony Nguyen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a3e37102-1f74-a9f4-d202-79c94add0afd@intel.com \
--to=anthony.l.nguyen@intel.com \
--cc=benjamin.mikailenko@intel.com \
--cc=grzegorz.siwik@intel.com \
--cc=intel-wired-lan@lists.osuosl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox