Re: [Intel-wired-lan] [PATCH iwl-next v2 6/6] ice: refactor ice_ptp_hw to make functions static

[Przemek Kitszel <przemyslaw.kitszel@intel.com>]

On 8/1/23 13:53, Jan Sokolowski wrote:
> efactor ice_ptp_hw.c/h in order to make as many methods

"efactor" is a typo :)

anyway I would try to use different word (for whole series), as 
"refactor" suggests that there are possibly some changes other than just 
"+static" and "move function up".

For this particular patch I would suggest:
ice: mark some ice_ptp_hw functions static
?

Also, for whole series, you have to CC netdev ML when sending patches to IWL

> as possible static.
> 
> Signed-off-by: Jan Sokolowski <jan.sokolowski@intel.com>
> ---
>   drivers/net/ethernet/intel/ice/ice_ptp_hw.c | 6 +++---
>   drivers/net/ethernet/intel/ice/ice_ptp_hw.h | 3 ---
>   2 files changed, 3 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/net/ethernet/intel/ice/ice_ptp_hw.c b/drivers/net/ethernet/intel/ice/ice_ptp_hw.c
> index dd2fad831924..fd19afaf9c85 100644
> --- a/drivers/net/ethernet/intel/ice/ice_ptp_hw.c
> +++ b/drivers/net/ethernet/intel/ice/ice_ptp_hw.c
> @@ -295,7 +295,7 @@ static bool ice_is_40b_phy_reg_e822(u16 low_addr, u16 *high_addr)
>    *
>    * Read a PHY register for the given port over the device sideband queue.
>    */
> -int
> +static int
>   ice_read_phy_reg_e822(struct ice_hw *hw, u8 port, u16 offset, u32 *val)
>   {
>   	struct ice_sbq_msg_input msg = {0};
> @@ -372,7 +372,7 @@ ice_read_64b_phy_reg_e822(struct ice_hw *hw, u8 port, u16 low_addr, u64 *val)
>    *
>    * Write a PHY register for the given port over the device sideband queue.
>    */
> -int
> +static int
>   ice_write_phy_reg_e822(struct ice_hw *hw, u8 port, u16 offset, u32 val)
>   {
>   	struct ice_sbq_msg_input msg = {0};
> @@ -1089,7 +1089,7 @@ ice_ptp_prep_phy_time_e822(struct ice_hw *hw, u32 time)
>    *
>    * Negative adjustments are supported using 2s complement arithmetic.
>    */
> -int
> +static int
>   ice_ptp_prep_port_adj_e822(struct ice_hw *hw, u8 port, s64 time)
>   {
>   	u32 l_time, u_time;
> diff --git a/drivers/net/ethernet/intel/ice/ice_ptp_hw.h b/drivers/net/ethernet/intel/ice/ice_ptp_hw.h
> index 3dc1d6e5468c..4e3c1382c477 100644
> --- a/drivers/net/ethernet/intel/ice/ice_ptp_hw.h
> +++ b/drivers/net/ethernet/intel/ice/ice_ptp_hw.h
> @@ -144,11 +144,8 @@ int ice_ptp_init_phc(struct ice_hw *hw);
>   int ice_get_phy_tx_tstamp_ready(struct ice_hw *hw, u8 block, u64 *tstamp_ready);
>   
>   /* E822 family functions */
> -int ice_read_phy_reg_e822(struct ice_hw *hw, u8 port, u16 offset, u32 *val);
> -int ice_write_phy_reg_e822(struct ice_hw *hw, u8 port, u16 offset, u32 val);
>   int ice_read_quad_reg_e822(struct ice_hw *hw, u8 quad, u16 offset, u32 *val);
>   int ice_write_quad_reg_e822(struct ice_hw *hw, u8 quad, u16 offset, u32 val);
> -int ice_ptp_prep_port_adj_e822(struct ice_hw *hw, u8 port, s64 time);
>   void ice_ptp_reset_ts_memory_quad_e822(struct ice_hw *hw, u8 quad);
>   
>   /**

_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan