Re: [Intel-wired-lan] [PATCH iwl-next v2 4/6] ice: refactor ice_vf_lib to make functions static

[Tony Nguyen <anthony.l.nguyen@intel.com>]

On 8/1/2023 6:25 AM, Przemek Kitszel wrote:
> On 8/1/23 13:53, Jan Sokolowski wrote:
>> Refactor ice_vf_lib.c/_private.h in order to make as many methods
>> as possible static.
>>
>> Signed-off-by: Jan Sokolowski <jan.sokolowski@intel.com>
>> ---
>>   drivers/net/ethernet/intel/ice/ice_vf_lib.c   | 468 +++++++++---------
>>   .../ethernet/intel/ice/ice_vf_lib_private.h   |   2 -
>>   2 files changed, 234 insertions(+), 236 deletions(-)
> 
> I don't like such big code movement to achieve something that two 
> predeclarations would provide.

To me this is not different than the other patches/intent; this just 
happens to involve more lines. Seems arbitrary to allow the others but 
not this one. I'm ok with sending this on to see if netdev will accept. 
Based on comments, I believe v3 will include netdev so we'll get an idea 
if they are open to this change with the next revision.

> We could either just abandon idea of converting those two functions,
> or move predeclarations, augmented by "static" keyword, to ice_vf.lib.c
> 
> That would slightly violate "the style", but you will achieve SAME THING.
> 
> I have tried locally to see the diff size:
>   drivers/net/ethernet/intel/ice/ice_vf_lib.c         | 7 +++++--
>   drivers/net/ethernet/intel/ice/ice_vf_lib_private.h | 2 --
>   2 files changed, 5 insertions(+), 4 deletions(-)
> 
> -Przemek
> 
> [...half thousand lines snipped...]
> _______________________________________________
> Intel-wired-lan mailing list
> Intel-wired-lan@osuosl.org
> https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan