From: Tony Nguyen <anthony.l.nguyen@intel.com>
To: Muhammad Husaini Zulkifli <muhammad.husaini.zulkifli@intel.com>,
<intel-wired-lan@osuosl.org>
Subject: Re: [Intel-wired-lan] [PATCH iwl-net v2 1/2] igc: Expose tx-usecs coalesce setting to user
Date: Wed, 12 Jul 2023 13:39:15 -0700 [thread overview]
Message-ID: <40071625-9e78-7837-2ae4-df167932aaf4@intel.com> (raw)
In-Reply-To: <20230711003453.9856-2-muhammad.husaini.zulkifli@intel.com>
On 7/10/2023 5:34 PM, Muhammad Husaini Zulkifli wrote:
...
> }
> @@ -910,9 +908,6 @@ static int igc_ethtool_set_coalesce(struct net_device *netdev,
> ec->tx_coalesce_usecs == 2)
> return -EINVAL;
>
> - if ((adapter->flags & IGC_FLAG_QUEUE_PAIRS) && ec->tx_coalesce_usecs)
> - return -EINVAL;
> -
Seems like this belongs in patch 2?
> /* If ITR is disabled, disable DMAC */
> if (ec->rx_coalesce_usecs == 0) {
> if (adapter->flags & IGC_FLAG_DMAC)
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
next prev parent reply other threads:[~2023-07-12 20:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-11 0:34 [Intel-wired-lan] [PATCH iwl-net v2 0/2] Enhance the tx-usecs coalesce setting implementation Muhammad Husaini Zulkifli
2023-07-11 0:34 ` [Intel-wired-lan] [PATCH iwl-net v2 1/2] igc: Expose tx-usecs coalesce setting to user Muhammad Husaini Zulkifli
2023-07-12 20:39 ` Tony Nguyen [this message]
2023-07-13 0:09 ` Zulkifli, Muhammad Husaini
2023-07-25 11:04 ` naamax.meir
2023-07-11 0:34 ` [Intel-wired-lan] [PATCH iwl-net v2 2/2] igc: Modify the tx-usecs coalesce setting Muhammad Husaini Zulkifli
2023-07-26 11:56 ` naamax.meir
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40071625-9e78-7837-2ae4-df167932aaf4@intel.com \
--to=anthony.l.nguyen@intel.com \
--cc=intel-wired-lan@osuosl.org \
--cc=muhammad.husaini.zulkifli@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox