Re: [Intel-wired-lan] [PATCH net-next v4 3/3] ice: Enable switching default tx scheduler topology

From: Tony Nguyen <anthony.l.nguyen@intel.com>
To: "Wilczynski, Michal" <michal.wilczynski@intel.com>,
	<intel-wired-lan@lists.osuosl.org>
Subject: Re: [Intel-wired-lan] [PATCH net-next v4 3/3] ice: Enable switching default tx scheduler topology
Date: Thu, 14 Jul 2022 13:31:54 -0700	[thread overview]
Message-ID: <4cc6a468-1ff9-a894-543a-7baa29500aa2@intel.com> (raw)
In-Reply-To: <beb3878b-df7a-2925-9a88-39e806b9eade@intel.com>

On 7/12/2022 12:51 AM, Wilczynski, Michal wrote:
> 
> 
> On 7/12/2022 2:25 AM, Tony Nguyen wrote:
>>
>>
>> On 7/4/2022 5:32 AM, Michal Wilczynski wrote:
>>> Introduce support for tx scheduler topology change, based on user
>>> selection, from default 9-layer to 5-layer. In order for switch to be
>>> successful there is a new NVM(version 3.20 or older) and DDP package(OS
>>> Package 1.3.29 or older).
>>>
>>> Enable 5-layer topology switch in init path of the driver. To accomplish
>>> that upload of the DDP package needs to be delayed, until change in Tx
>>> topology is finished. To trigger the Tx change user selection should be
>>> changed in NVM using devlink. Then the platform should be rebooted.
>>>
>>> Example way of switching NVM settings in devlink:
>>>
>>> Show:
>>> devlink dev param show pci/0000:4b:00.0
>>>    name txbalancing type driver-specific
>>>      values:
>>>        cmode permanent value true
>>>
>>> Set:
>>> devlink dev param set pci/0000:4b:00.0 name txbalancing value true cmode
>>> permanent
>>
>> Did I miss the devlink implementation?
> 
> It's not upstreamed yet, however I had to provide some example on how 
> this might be
> configured. There was a review comment about that. I tested it by using 
> epct with OOT
> driver first. Obviously I can't provide this method for upstream community.

As there is a plan to send the devlink implementation soon, these should 
all be put together into a series that has the functionality as well as 
the ability to get/set it. If it is too large for a series, provide some 
method to view the other portions of code such as RFC patches or point 
to a repo that contains it.

I don't believe functionality that would, currently, require installing 
the OOT driver to change modes is acceptable.
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan