Re: [Intel-wired-lan] [PATCH net-next v4 3/3] ice: Enable switching default tx scheduler topology

["Wilczynski, Michal" <michal.wilczynski@intel.com>]

On 7/12/2022 2:25 AM, Tony Nguyen wrote:
>
>
> On 7/4/2022 5:32 AM, Michal Wilczynski wrote:
>> Introduce support for tx scheduler topology change, based on user
>> selection, from default 9-layer to 5-layer. In order for switch to be
>> successful there is a new NVM(version 3.20 or older) and DDP package(OS
>> Package 1.3.29 or older).
>>
>> Enable 5-layer topology switch in init path of the driver. To accomplish
>> that upload of the DDP package needs to be delayed, until change in Tx
>> topology is finished. To trigger the Tx change user selection should be
>> changed in NVM using devlink. Then the platform should be rebooted.
>>
>> Example way of switching NVM settings in devlink:
>>
>> Show:
>> devlink dev param show pci/0000:4b:00.0
>>    name txbalancing type driver-specific
>>      values:
>>        cmode permanent value true
>>
>> Set:
>> devlink dev param set pci/0000:4b:00.0 name txbalancing value true cmode
>> permanent
>
> Did I miss the devlink implementation?

It's not upstreamed yet, however I had to provide some example on how 
this might be
configured. There was a review comment about that. I tested it by using 
epct with OOT
driver first. Obviously I can't provide this method for upstream community.

>
>> Signed-off-by: Michal Wilczynski <michal.wilczynski@intel.com>
>> ---
>
> <snip>

Can't figure out what's wrong here ? Signed-off seems to be okay.

>
>
>> +static int ice_init_tx_topology(struct ice_hw *hw,
>> +                const struct firmware *firmware)
>> +{
>> +    u8 num_tx_sched_layers = hw->num_tx_sched_layers;
>> +    struct ice_pf *pf = hw->back;
>> +    struct device *dev;
>> +    u8 *buf_copy;
>> +    int err;
>> +
>> +    dev = ice_pf_to_dev(pf);
>> +    /* ice_cfg_tx_topo buf argument is not a constant,
>> +     * so we have to make a copy
>> +     */
>> +    buf_copy = kmemdup(firmware->data, firmware->size, GFP_KERNEL);
>> +
>> +    err = ice_cfg_tx_topo(hw, buf_copy, firmware->size);
>> +    if (!err) {
>> +        if (hw->num_tx_sched_layers > num_tx_sched_layers)
>> +            dev_info(dev, "Transmit balancing feature disabled\n");
>> +        else
>> +            dev_info(dev, "Transmit balancing feature enabled\n");
>> +
>> +        /* if there was a change in topology ice_cfg_tx_topo triggered
>> +         * a CORER and we need to re-init hw.
>> +         */
>> +        ice_deinit_hw(hw);
>> +        err = ice_init_hw(hw);
>> +
>> +        /* in this case we're not allowing safe mode */
>> +        devm_kfree(ice_hw_to_dev(hw), buf_copy);
>
>         This should be a kfree now.


yep thanks

>
>> +
>> +        return err;
>> +
>> +    } else if (err == -EIO) {
>> +        dev_info(dev, "DDP package does not support transmit 
>> balancing feature - please update to the latest DDP package and try 
>> again\n");
>> +    }
>> +
>> +    kfree(buf_copy);
>> +
>> +    return 0;
>> +}
>> +

_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan