From: Jacob Keller <jacob.e.keller@intel.com>
To: Simon Horman <horms@kernel.org>, Yue Haibing <yuehaibing@huawei.com>
Cc: alexander.h.duyck@intel.com, andre.guedes@intel.com,
maciej.fijalkowski@intel.com, hawk@kernel.org,
daniel@iogearbox.net, jithu.joseph@intel.com,
przemyslaw.kitszel@intel.com, john.fastabend@gmail.com,
ast@kernel.org, linux-kernel@vger.kernel.org,
edumazet@google.com, netdev@vger.kernel.org,
anthony.l.nguyen@intel.com, intel-wired-lan@lists.osuosl.org,
kuba@kernel.org, bpf@vger.kernel.org, pabeni@redhat.com,
davem@davemloft.net, vedang.patel@intel.com
Subject: Re: [Intel-wired-lan] [PATCH v3 net 0/4] Fix passing 0 to ERR_PTR in intel ether drivers
Date: Tue, 22 Oct 2024 12:17:07 -0700 [thread overview]
Message-ID: <584b87a4-4a69-4119-bcd8-d4561f41ed53@intel.com> (raw)
In-Reply-To: <20241022073225.GO402847@kernel.org>
On 10/22/2024 12:32 AM, Simon Horman wrote:
> On Tue, Oct 22, 2024 at 02:56:19PM +0800, Yue Haibing wrote:
>> Fixing sparse error in xdp run code by introducing new variable xdp_res
>> instead of overloading this into the skb pointer as i40e drivers done
>> in commit 12738ac4754e ("i40e: Fix sparse errors in i40e_txrx.c") and
>> commit ae4393dfd472 ("i40e: fix broken XDP support").
>>
>> v3: Fix uninitialized 'xdp_res' in patch 3 and 4 which Reported-by
>> kernel test robot
>> v2: Fix this as i40e drivers done instead of return NULL in xdp run code
>
> Hi Yue Haibing, all,
>
> I like these changes a lot. But I do wonder if it would
> be more appropriate to target them at net-next (or iwl-next)
> rather than net, without Fixes tags. This is because they
> don't seem to be fixing (user-visible) bugs. Am I missing something?
>
> ...
Yea, these do seem like next candidates.
next prev parent reply other threads:[~2024-10-22 19:17 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-22 6:56 [Intel-wired-lan] [PATCH v3 net 0/4] Fix passing 0 to ERR_PTR in intel ether drivers Yue Haibing
2024-10-22 6:56 ` [Intel-wired-lan] [PATCH v3 net 1/4] igc: Fix passing 0 to ERR_PTR in igc_xdp_run_prog() Yue Haibing
2024-10-22 6:56 ` [Intel-wired-lan] [PATCH v3 net 2/4] igb: Fix passing 0 to ERR_PTR in igb_run_xdp() Yue Haibing
2024-10-22 6:56 ` [Intel-wired-lan] [PATCH v3 net 3/4] ixgbe: Fix passing 0 to ERR_PTR in ixgbe_run_xdp() Yue Haibing
2024-10-22 11:25 ` Maciej Fijalkowski
2024-10-22 6:56 ` [Intel-wired-lan] [PATCH v3 net 4/4] ixgbevf: Fix passing 0 to ERR_PTR in ixgbevf_run_xdp() Yue Haibing
2024-10-22 11:27 ` Maciej Fijalkowski
2024-10-22 7:32 ` [Intel-wired-lan] [PATCH v3 net 0/4] Fix passing 0 to ERR_PTR in intel ether drivers Simon Horman
2024-10-22 19:17 ` Jacob Keller [this message]
2024-10-25 3:30 ` Yue Haibing
2024-10-25 4:11 ` Przemek Kitszel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=584b87a4-4a69-4119-bcd8-d4561f41ed53@intel.com \
--to=jacob.e.keller@intel.com \
--cc=alexander.h.duyck@intel.com \
--cc=andre.guedes@intel.com \
--cc=anthony.l.nguyen@intel.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hawk@kernel.org \
--cc=horms@kernel.org \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jithu.joseph@intel.com \
--cc=john.fastabend@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maciej.fijalkowski@intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=przemyslaw.kitszel@intel.com \
--cc=vedang.patel@intel.com \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox