From: Przemek Kitszel <przemyslaw.kitszel@intel.com>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: Karol Kolacinski <karol.kolacinski@intel.com>,
Tony Nguyen <anthony.l.nguyen@intel.com>,
netdev@vger.kernel.org,
Richard Cochran <richardcochran@gmail.com>,
LKML <linux-kernel@vger.kernel.org>,
Eric Dumazet <edumazet@google.com>,
intel-wired-lan@lists.osuosl.org,
Jacob Keller <jacob.e.keller@intel.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [Intel-wired-lan] [PATCH] ice: Use common error handling code in two functions
Date: Fri, 20 Sep 2024 08:34:46 +0200 [thread overview]
Message-ID: <58d38533-bccd-4e0e-8c7a-4f7a122ce0d1@intel.com> (raw)
In-Reply-To: <f3a2dbaf-a280-40c8-bacf-b4f0c9b0b7fe@web.de>
On 9/19/24 19:15, Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Thu, 19 Sep 2024 19:00:25 +0200
>
> Add jump targets so that a bit of exception handling can be better reused
> at the end of two function implementations.
Thank you for contribution, the change is fine, but not as a bugfix.
Please send as a [iwl-next], when the submission window opens.
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
> @@ -3168,6 +3164,10 @@ static int ice_ptp_init_owner(struct ice_pf *pf)
> pf->ptp.clock = NULL;
> err_exit:
> return err;
> +
> +err_unlock:
> + ice_ptp_unlock(hw);
> + return err;
> }
You kept the current label naming scheme, that's good.
next prev parent reply other threads:[~2024-09-20 6:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-19 17:15 [Intel-wired-lan] [PATCH] ice: Use common error handling code in two functions Markus Elfring
2024-09-19 17:50 ` Keller, Jacob E
2024-09-20 6:34 ` Przemek Kitszel [this message]
2024-09-20 7:05 ` [Intel-wired-lan] " Markus Elfring
2024-09-23 18:23 ` Tony Nguyen
2024-10-04 10:52 ` [Intel-wired-lan] [PATCH] " Pucha, HimasekharX Reddy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=58d38533-bccd-4e0e-8c7a-4f7a122ce0d1@intel.com \
--to=przemyslaw.kitszel@intel.com \
--cc=Markus.Elfring@web.de \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jacob.e.keller@intel.com \
--cc=karol.kolacinski@intel.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=richardcochran@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox