From: Markus Elfring <Markus.Elfring@web.de>
To: Przemek Kitszel <przemyslaw.kitszel@intel.com>,
intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org
Cc: Richard Cochran <richardcochran@gmail.com>,
Karol Kolacinski <karol.kolacinski@intel.com>,
LKML <linux-kernel@vger.kernel.org>,
Eric Dumazet <edumazet@google.com>,
Tony Nguyen <anthony.l.nguyen@intel.com>,
Jacob Keller <jacob.e.keller@intel.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [Intel-wired-lan] ice: Use common error handling code in two functions
Date: Fri, 20 Sep 2024 09:05:11 +0200 [thread overview]
Message-ID: <d9ee8571-208a-45cb-ad51-61926ce23d62@web.de> (raw)
In-Reply-To: <58d38533-bccd-4e0e-8c7a-4f7a122ce0d1@intel.com>
>> Add jump targets so that a bit of exception handling can be better reused
>> at the end of two function implementations.
>
> Thank you for contribution, the change is fine,
Thanks for this positive feedback.
> but not as a bugfix.
Would you like to qualify my update suggestion as a correction for
a coding style issue?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/coding-style.rst?h=v6.11#n526
> Please send as a [iwl-next], when the submission window opens.
Will a patch resend really be needed for the proposed adjustment?
Regards,
Markus
next prev parent reply other threads:[~2024-09-20 7:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-19 17:15 [Intel-wired-lan] [PATCH] ice: Use common error handling code in two functions Markus Elfring
2024-09-19 17:50 ` Keller, Jacob E
2024-09-20 6:34 ` Przemek Kitszel
2024-09-20 7:05 ` Markus Elfring [this message]
2024-09-23 18:23 ` [Intel-wired-lan] " Tony Nguyen
2024-10-04 10:52 ` [Intel-wired-lan] [PATCH] " Pucha, HimasekharX Reddy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d9ee8571-208a-45cb-ad51-61926ce23d62@web.de \
--to=markus.elfring@web.de \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jacob.e.keller@intel.com \
--cc=karol.kolacinski@intel.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=przemyslaw.kitszel@intel.com \
--cc=richardcochran@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox